Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XP-Style window decoration on Vista #5

Open
casper opened this issue Dec 23, 2019 · 1 comment
Open

XP-Style window decoration on Vista #5

casper opened this issue Dec 23, 2019 · 1 comment

Comments

@casper
Copy link

casper commented Dec 23, 2019

I've been using PuttyTray previously, but wanted to switch to your version for 24-bit color support.

Your version works fine, but why does it not use the normal UI theme (Vista with the default theme, see image below)?

PuttyTray looks like any other window on my desktop, with the proper theme decoration, but your version gets the XP treatment.

Any idea why that happens? I tried to look at the source code, but the CreateWindow() call in window.c seem identical in both repositories. Is there something else that triggers this UI difference?

image

@casper
Copy link
Author

casper commented Dec 24, 2019

I figured it out. Well, partially. Here is a response from the PuTTY maintainers:

I'm afraid the most likely culprit I could see is the locking down
of the DLL search path to prevent hijacking attacks.

If you're able to build PuTTY yourself, you could try removing the call
to dll_hijacking_protection() at the start of WinMain() in
windows/window.c and see if that makes a difference.

Removing dll_hijacking_protection restores the proper theme decoration. But this of course then prevents hijacking protection.

Don't know how to fix both of these issues at the same time, but at least I know where the problem is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant