Skip to content

Commit c188d6b

Browse files
authored
Merge pull request #558 from elsassph/fix/update-types
Update types
2 parents 679f5a7 + cc6ba46 commit c188d6b

19 files changed

+728
-158
lines changed

package-lock.json

Lines changed: 619 additions & 130 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"@babel/plugin-transform-spread": "^7.8.3",
5555
"@babel/preset-env": "^7.8.3",
5656
"@rollup/plugin-babel": "^6.0.3",
57-
"@types/node": "^18.14.0",
57+
"@types/node": "^20.0.0",
5858
"@vitejs/plugin-legacy": "^3.0.1",
5959
"chai": "^4.2.0",
6060
"concurrently": "^7.6.0",
@@ -65,9 +65,9 @@
6565
"shx": "^0.3.4",
6666
"sinon": "^7.5.0",
6767
"terser": "^5.16.8",
68-
"tsd": "^0.21.0",
69-
"typedoc": "^0.23.21",
70-
"typescript": "^4.9.5",
68+
"tsd": "^0.31.2",
69+
"typedoc": "^0.27.5",
70+
"typescript": "~5.3.3",
7171
"vite": "^4.0.4",
7272
"vitest": "^0.27.2"
7373
}

src/components/BloomComponent.d.mts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ declare namespace BloomComponent {
4949
declare class BloomComponent<ContentType extends Element = Element>
5050
extends Component<BloomComponent.TemplateSpec<ContentType>>
5151
{
52-
// @ts-expect-error Prevent ts(2380)
5352
get content(): ContentType;
5453
set content(v: Element.PatchTemplate<Element.ExtractTemplateSpec<ContentType>>);
5554

src/components/BorderComponent.d.mts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ declare namespace BorderComponent {
128128
declare class BorderComponent<ContentType extends Element = Element>
129129
extends Component<BorderComponent.TemplateSpec<ContentType>>
130130
{
131-
// @ts-expect-error Prevent ts(2380)
132131
get content(): ContentType;
133132
set content(v: Element.PatchTemplate<Element.ExtractTemplateSpec<ContentType>>);
134133

src/components/FastBlurComponent.d.mts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ declare class FastBlurComponent<
5151
>
5252
extends Component<FastBlurComponent.TemplateSpec<ContentType>>
5353
{
54-
// @ts-expect-error Prevent ts(2380)
5554
get content(): ContentType;
5655
set content(v: Element.PatchTemplate<Element.ExtractTemplateSpec<ContentType>>);
5756

src/components/SmoothScaleComponent.d.mts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ declare class SmoothScaleComponent<
3737
>
3838
extends Component<SmoothScaleComponent.TemplateSpec<ContentType>>
3939
{
40-
// @ts-expect-error Prevent ts(2380)
4140
get content(): ContentType;
4241
set content(content: Element.PatchTemplate<Element.ExtractTemplateSpec<ContentType>>);
4342
smoothScale: number;

src/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ import C2dBlurShader from "./renderer/c2d/shaders/BlurShader.mjs";
7575
import SpinnerShader2 from "./renderer/webgl/shaders/SpinnerShader2.mjs";
7676

7777
import Stage from "./tree/Stage.mjs";
78+
import WebPlatform from "./platforms/browser/WebPlatform.mjs";
7879

7980
// full export (no tree-shaking)
8081
import lng from "./lightning.mjs";
@@ -135,4 +136,7 @@ export {
135136
ObjMerger,
136137
ObjectListProxy,
137138
ObjectListWrapper,
139+
WebPlatform,
138140
};
141+
142+
export type * from './types/lng.types.namespace.mjs';

src/platforms/browser/WebPlatform.d.mts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
import Stage from "../../tree/Stage.mjs";
2020
import TextureSource from "../../tree/TextureSource.mjs";
21+
import type StaticCanvasTexture from "../../textures/StaticCanvasTexture.mjs";
2122

2223
export default class WebPlatform {
2324
destroy(): void;
@@ -41,4 +42,5 @@ export default class WebPlatform {
4142
options: unknown,
4243
): void;
4344
getHrTime(): number;
45+
createSvg?: (cb: StaticCanvasTexture.FactoryCallback, stage: Stage, url: string, w: number, h: number) => void;
4446
}

src/textures/TextTexture.d.mts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import Stage from "../tree/Stage.mjs";
2020
import Texture from "../tree/Texture.mjs";
2121
import TextTextureRenderer from "./TextTextureRenderer.mjs";
22+
import TextTextureRendererAdvanced from "./TextTextureRendererAdvanced.mjs";
2223

2324
declare namespace TextTexture {
2425
/**
@@ -456,8 +457,8 @@ declare class TextTexture extends Texture implements Required<Omit<TextTexture.S
456457
protected static renderer(
457458
stage: Stage,
458459
canvas: HTMLCanvasElement,
459-
settings: TextTexture.Settings,
460-
): TextTextureRenderer;
460+
settings: TextTexture.Settings
461+
): TextTextureRenderer | TextTextureRendererAdvanced;
461462

462463
// protected _changed(): void;
463464
// protected stage: Stage;

src/textures/TextTexture.mjs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export default class TextTexture extends Texture {
3030
}
3131

3232
static renderer(stage, canvas, settings) {
33-
if (this.advancedRenderer) {
33+
if (settings.advancedRenderer) {
3434
return new TextTextureRendererAdvanced(stage, canvas, settings);
3535
} else {
3636
return new TextTextureRenderer(stage, canvas, settings);
@@ -549,9 +549,7 @@ export default class TextTexture extends Texture {
549549

550550
return function (cb) {
551551
const canvas = this.stage.platform.getDrawingCanvas();
552-
const renderer = (args.advancedRenderer)
553-
? new TextTextureRendererAdvanced(this.stage, canvas, args)
554-
: new TextTextureRenderer(this.stage, canvas, args);
552+
const renderer = TextTexture.renderer(this.stage, canvas, args);
555553

556554
const p = renderer.draw();
557555

0 commit comments

Comments
 (0)