Skip to content

Commit 01e1f2f

Browse files
authored
feat: remove shallowequal (#285)
1 parent e2b54c6 commit 01e1f2f

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
"@types/jest": "^26.0.0",
4545
"@types/react": "^18.0.0",
4646
"@types/react-dom": "^18.0.0",
47-
"@types/shallowequal": "^1.1.1",
4847
"@umijs/fabric": "^2.0.0",
4948
"cross-env": "^7.0.0",
5049
"dumi": "^1.1.4",
@@ -66,8 +65,7 @@
6665
"@babel/runtime": "^7.10.1",
6766
"classnames": "2.x",
6867
"rc-motion": "^2.3.4",
69-
"rc-util": "^5.2.1",
70-
"shallowequal": "^1.1.0"
68+
"rc-util": "^5.27.0"
7169
},
7270
"peerDependencies": {
7371
"react": ">=16.9.0",

src/Collapse.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import classNames from 'classnames';
33
import toArray from 'rc-util/lib/Children/toArray';
44
import * as React from 'react';
5-
import shallowEqual from 'shallowequal';
5+
import isEqual from 'rc-util/lib/isEqual';
66
import type { CollapseProps, CollapsibleType } from './interface';
77
import CollapsePanel from './Panel';
88

@@ -45,7 +45,7 @@ class Collapse extends React.Component<CollapseProps, CollapseState> {
4545
}
4646

4747
shouldComponentUpdate(nextProps: CollapseProps, nextState: CollapseState) {
48-
return !shallowEqual(this.props, nextProps) || !shallowEqual(this.state, nextState);
48+
return !isEqual(this.props, nextProps, true) || !isEqual(this.state, nextState, true);
4949
}
5050

5151
onClickItem = (key: React.Key) => {

src/Panel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import classNames from 'classnames';
33
import CSSMotion from 'rc-motion';
44
import * as React from 'react';
5-
import shallowEqual from 'shallowequal';
5+
import isEqual from 'rc-util/lib/isEqual';
66
import type { CollapsePanelProps } from './interface';
77
import PanelContent from './PanelContent';
88

@@ -16,7 +16,7 @@ class CollapsePanel extends React.Component<CollapsePanelProps, any> {
1616
};
1717

1818
shouldComponentUpdate(nextProps: CollapsePanelProps) {
19-
return !shallowEqual(this.props, nextProps);
19+
return !isEqual(this.props, nextProps, true);
2020
}
2121

2222
onItemClick = () => {

0 commit comments

Comments
 (0)