From 03719241c0dfc8c84cb7f340a60069e0c8a25766 Mon Sep 17 00:00:00 2001 From: Logan <37604784+imlogang@users.noreply.github.com> Date: Thu, 29 Feb 2024 12:58:33 -0700 Subject: [PATCH 1/5] Update description for resource class parameter and update default MacOS Executor as medium is deprecated. --- src/executors/linux_android.yml | 2 +- src/executors/linux_js.yml | 2 +- src/executors/macos.yml | 4 ++-- src/jobs/android_build.yml | 2 +- src/jobs/android_test.yml | 2 +- src/jobs/ios_build.yml | 2 +- src/jobs/ios_build_and_test.yml | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/executors/linux_android.yml b/src/executors/linux_android.yml index df3c494..dab33ec 100644 --- a/src/executors/linux_android.yml +++ b/src/executors/linux_android.yml @@ -8,7 +8,7 @@ parameters: type: string default: '5.1' resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium docker: diff --git a/src/executors/linux_js.yml b/src/executors/linux_js.yml index dcd0ed4..e70b629 100644 --- a/src/executors/linux_js.yml +++ b/src/executors/linux_js.yml @@ -4,7 +4,7 @@ parameters: type: string default: '16.15' resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium docker: diff --git a/src/executors/macos.yml b/src/executors/macos.yml index a73dd5f..2f2fba0 100644 --- a/src/executors/macos.yml +++ b/src/executors/macos.yml @@ -4,9 +4,9 @@ parameters: type: string default: "12.5.1" resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string - default: medium + default: macos.x86.medium.gen2 macos: xcode: <> resource_class: <> diff --git a/src/jobs/android_build.yml b/src/jobs/android_build.yml index 59665fc..8c0e709 100644 --- a/src/jobs/android_build.yml +++ b/src/jobs/android_build.yml @@ -56,7 +56,7 @@ parameters: type: string default: '5.1' resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium diff --git a/src/jobs/android_test.yml b/src/jobs/android_test.yml index 85572ac..50132d3 100644 --- a/src/jobs/android_test.yml +++ b/src/jobs/android_test.yml @@ -79,7 +79,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium diff --git a/src/jobs/ios_build.yml b/src/jobs/ios_build.yml index 0f277b1..db8956c 100644 --- a/src/jobs/ios_build.yml +++ b/src/jobs/ios_build.yml @@ -84,7 +84,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium diff --git a/src/jobs/ios_build_and_test.yml b/src/jobs/ios_build_and_test.yml index 49510db..d325408 100644 --- a/src/jobs/ios_build_and_test.yml +++ b/src/jobs/ios_build_and_test.yml @@ -98,7 +98,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: Changes the resource class of the executor. Requires a support request to enable the resource_class parameter. See https://circleci.com/docs/2.0/configuration-reference/#resource_class + description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ type: string default: medium From ba54b81869561a157086aded3decf6a5dc6dae5e Mon Sep 17 00:00:00 2001 From: Logan <37604784+imlogang@users.noreply.github.com> Date: Fri, 1 Mar 2024 10:56:01 -0700 Subject: [PATCH 2/5] docs: update description for resource class parameter --- src/executors/linux_android.yml | 2 +- src/executors/linux_js.yml | 2 +- src/executors/macos.yml | 2 +- src/jobs/android_build.yml | 2 +- src/jobs/android_test.yml | 2 +- src/jobs/ios_build.yml | 2 +- src/jobs/ios_build_and_test.yml | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/executors/linux_android.yml b/src/executors/linux_android.yml index dab33ec..2eb374a 100644 --- a/src/executors/linux_android.yml +++ b/src/executors/linux_android.yml @@ -8,7 +8,7 @@ parameters: type: string default: '5.1' resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium docker: diff --git a/src/executors/linux_js.yml b/src/executors/linux_js.yml index e70b629..31e981e 100644 --- a/src/executors/linux_js.yml +++ b/src/executors/linux_js.yml @@ -4,7 +4,7 @@ parameters: type: string default: '16.15' resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium docker: diff --git a/src/executors/macos.yml b/src/executors/macos.yml index 2f2fba0..d97a92d 100644 --- a/src/executors/macos.yml +++ b/src/executors/macos.yml @@ -4,7 +4,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: macos.x86.medium.gen2 macos: diff --git a/src/jobs/android_build.yml b/src/jobs/android_build.yml index 8c0e709..6e2f2c9 100644 --- a/src/jobs/android_build.yml +++ b/src/jobs/android_build.yml @@ -56,7 +56,7 @@ parameters: type: string default: '5.1' resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium diff --git a/src/jobs/android_test.yml b/src/jobs/android_test.yml index 50132d3..24565b2 100644 --- a/src/jobs/android_test.yml +++ b/src/jobs/android_test.yml @@ -79,7 +79,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium diff --git a/src/jobs/ios_build.yml b/src/jobs/ios_build.yml index db8956c..1aaff66 100644 --- a/src/jobs/ios_build.yml +++ b/src/jobs/ios_build.yml @@ -84,7 +84,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium diff --git a/src/jobs/ios_build_and_test.yml b/src/jobs/ios_build_and_test.yml index d325408..2fe523b 100644 --- a/src/jobs/ios_build_and_test.yml +++ b/src/jobs/ios_build_and_test.yml @@ -98,7 +98,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. https://circleci.com/product/features/resource-classes/ + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass type: string default: medium From 25094e1f6a6182564b5c113766682398d48f9158 Mon Sep 17 00:00:00 2001 From: Logan <37604784+imlogang@users.noreply.github.com> Date: Fri, 1 Mar 2024 10:57:17 -0700 Subject: [PATCH 3/5] docs: update reosurce class for macos to link to correct docs --- src/jobs/ios_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jobs/ios_build.yml b/src/jobs/ios_build.yml index 1aaff66..7aa47b7 100644 --- a/src/jobs/ios_build.yml +++ b/src/jobs/ios_build.yml @@ -84,7 +84,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/using-macos/#available-resource-classes type: string default: medium From e55f117fb38619182971f3f10eb625cd4a9e1a44 Mon Sep 17 00:00:00 2001 From: Logan <37604784+imlogang@users.noreply.github.com> Date: Fri, 1 Mar 2024 10:58:04 -0700 Subject: [PATCH 4/5] feat: change default macos executor to macos.x86.medium.gen2. Breaking change as medium is deprecated --- src/jobs/ios_build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/jobs/ios_build.yml b/src/jobs/ios_build.yml index 7aa47b7..285021f 100644 --- a/src/jobs/ios_build.yml +++ b/src/jobs/ios_build.yml @@ -86,7 +86,7 @@ parameters: resource_class: description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/using-macos/#available-resource-classes type: string - default: medium + default: macos.x86.medium.gen2 executor: name: macos From 6dc9e631457fb514bfffa0eb225319b62109bb72 Mon Sep 17 00:00:00 2001 From: Logan <37604784+imlogang@users.noreply.github.com> Date: Fri, 1 Mar 2024 10:59:25 -0700 Subject: [PATCH 5/5] docs: update macos executor with the correct resource class link --- src/executors/macos.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/executors/macos.yml b/src/executors/macos.yml index d97a92d..0fe1793 100644 --- a/src/executors/macos.yml +++ b/src/executors/macos.yml @@ -4,7 +4,7 @@ parameters: type: string default: "12.5.1" resource_class: - description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/configuration-reference/#resourceclass + description: You can use whatever resource class your plan has access to. See https://circleci.com/docs/using-macos/#available-resource-classes type: string default: macos.x86.medium.gen2 macos: