Skip to content

Commit 4413448

Browse files
dustinsoftwareDaniel15
authored andcommitted
Fix xUnit tests in VS2017 (#474)
Due to an xUnit bug, tests would attempt to run, but then fail immediately. Updating the packages fixes the issue. microsoft/vstest#811
1 parent 2e6b9a7 commit 4413448

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

tests/React.Tests/Mvc/HtmlHelperExtensionsTests.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*
1+
/*
22
* Copyright (c) 2014-Present, Facebook, Inc.
33
* All rights reserved.
44
*
@@ -13,7 +13,7 @@
1313

1414
namespace React.Tests.Mvc
1515
{
16-
class HtmlHelperExtensionsTests
16+
public class HtmlHelperExtensionsTests
1717
{
1818
/// <summary>
1919
/// Creates a mock <see cref="IReactEnvironment"/> and registers it with the IoC container

tests/React.Tests/React.Tests.csproj

+4-4
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
</ItemGroup>
2424

2525
<ItemGroup>
26-
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" />
26+
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.5.0" />
2727
<PackageReference Include="Moq" Version="4.5.30" />
28-
<PackageReference Include="xunit" Version="2.3.0-beta1-build3642" />
29-
<PackageReference Include="xunit.runner.visualstudio" Version="2.2.0" />
30-
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.0-beta1-build3642" />
28+
<PackageReference Include="xunit" Version="2.3.1" />
29+
<PackageReference Include="xunit.runner.visualstudio" Version="2.3.1" />
30+
<DotNetCliToolReference Include="dotnet-xunit" Version="2.3.1" />
3131
</ItemGroup>
3232

3333
<ItemGroup Condition=" '$(TargetFramework)' == 'net452' ">

0 commit comments

Comments
 (0)