Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Lesson 13 - Rending HTML for root path ('/') #247

Open
pisrael opened this issue Oct 5, 2016 · 2 comments
Open

Lesson 13 - Rending HTML for root path ('/') #247

pisrael opened this issue Oct 5, 2016 · 2 comments

Comments

@pisrael
Copy link

pisrael commented Oct 5, 2016

Following the lesson 13 tutorial I wasn't able to render the full server side HTML for the root path ('/'). This is a very important thing for apps that relies on SEO.

The router:
screen shot 2016-10-04 at 10 28 22 pm

The server code:
screen shot 2016-10-04 at 10 27 59 pm

The result for the URL localhost:8080
screen shot 2016-10-04 at 10 27 32 pm

Just as a benchmark, when requesting localhost:8080/about it works
screen shot 2016-10-04 at 10 33 02 pm

How could I fix this issue using ReactRouter and also get the full HTML for the root path?

[UPDATE]
I was able to fix it myself.

The solution is to delete index.html from the public folder.
I suggest in the tutorial to ask the reader to delete his index.html once server side rendering is completed.

@rajaraodv
Copy link

This should be fixed by this: #271

@maquino1985
Copy link

maquino1985 commented Jan 26, 2017

I ran into this same issue. When I fixed the issue (either deleting index.html or as described in #271 ) whenever I follow any link in the app, the server is called to rerender the page.

edit: I found the problem... a missing quote mark in the renderPage() function. Oy...

Also I noticed that in project 14 webpack.server.config.js is edited and node: __dirname and __filename are set to false instead of true. I don't know why but the inconsistency is confusing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants