Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progression range should update on columns change #35

Open
JayPanoz opened this issue Nov 29, 2024 · 1 comment
Open

Progression range should update on columns change #35

JayPanoz opened this issue Nov 29, 2024 · 1 comment
Assignees

Comments

@JayPanoz
Copy link
Contributor

It seems that progression range is not updated when switching from 1 to 2 columns, and vice-versa. It should behave as resizing the window width.

@JayPanoz
Copy link
Contributor Author

JayPanoz commented Dec 2, 2024

I’m afraid this is tied to ts-toolkit’s Preference API as a quick experiment on colCount change showed wrong numbers were reported due to the scrollWidth being “cached” and not updated. Now currentPositionNumbers relies on this to find the positions in view(port).

On resize, Playground is relying on the positionChanged listener, so it could be a good idea to make things consistent since changing the number of columns is conceptually a resize of sorts, as is scroll, font-size, font-family, etc. But then maybe this could be overloading this event quite significantly.

@HadrienGardeur HadrienGardeur removed the bug label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Draft
Development

No branches or pull requests

2 participants