Skip to content

Commit e42c4c3

Browse files
fix(python): ignore the middleware when groupingFn is None (#1199)
## 🧰 Changes Add a handler to ignore middleware when we have an empty groupingFn (grouping_function is None). ## 🧬 QA & Testing Try sending test requests with grouping function that returns None. In this case, the middleware should be ignored.
1 parent 3a2a0db commit e42c4c3

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/python/readme_metrics/django.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,15 @@ def process_response(self, request, response):
5858
self.config.LOGGER.exception(e)
5959

6060
def sync_process(self, request):
61-
if request.method == "OPTIONS":
61+
if request.method == "OPTIONS" or self.config.GROUPING_FUNCTION is None:
6262
return self.get_response(request)
6363
self.preamble(request)
6464
response = self.get_response(request)
6565
self.process_response(request, response)
6666
return response
6767

6868
async def async_process(self, request):
69-
if request.method == "OPTIONS":
69+
if request.method == "OPTIONS" or self.config.GROUPING_FUNCTION is None:
7070
return await self.get_response(request)
7171
self.preamble(request)
7272
response = await self.get_response(request)

packages/python/readme_metrics/fastapi.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ async def preamble(self, request):
5858
self.config.LOGGER.exception(e)
5959

6060
async def dispatch(self, request: Request, call_next):
61-
if request.method == "OPTIONS":
61+
if request.method == "OPTIONS" or self.config.GROUPING_FUNCTION is None:
6262
return await call_next(request)
6363

6464
await self.preamble(request)

packages/python/readme_metrics/flask_readme.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def init_app(self, app: Flask):
2727
app.after_request(self.after_request)
2828

2929
def before_request(self):
30-
if request.method == "OPTIONS":
30+
if request.method == "OPTIONS" or self.config.GROUPING_FUNCTION is None:
3131
return
3232

3333
try:

0 commit comments

Comments
 (0)