chore: test touchups, logging fixes

Author: kanadgupta

__tests__/cmds/openapi/convert.test.ts

@@ -76,6 +76,8 @@ describe('rdme openapi:convert', () => {
     it.each([['json'], ['yaml']])('should fail if given an OpenAPI 3.0 definition (format: %s)', async format => {
       const spec = require.resolve(`@readme/oas-examples/3.0/${format}/petstore.${format}`);
 
+      const consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+
       let reducedSpec;
       fs.writeFileSync = vi.fn((fileName, data) => {
         reducedSpec = JSON.parse(data as string);
@@ -104,6 +106,12 @@ describe('rdme openapi:convert', () => {
         '/user/{username}',
       ]);
       expect(Object.keys(reducedSpec.paths['/pet/{petId}'])).toStrictEqual(['get', 'post', 'delete']);
+
+      expect(consoleWarnSpy).toHaveBeenCalledWith(
+        '⚠️  Warning! The input file is already OpenAPI, so no conversion is necessary. Any external references will be bundled.',
+      );
+
+      consoleWarnSpy.mockRestore();
     });
   });
 });

__tests__/cmds/openapi/index.test.ts

@@ -931,16 +931,7 @@ describe('rdme openapi', () => {
         .reply(400, errorObject);
 
       await expect(
-        run([
-          './__tests__/__fixtures__/swagger-with-invalid-extensions.json',
-          // key,
-          // version,
-
-          '--key',
-          key,
-          '--version',
-          version,
-        ]),
+        run(['./__tests__/__fixtures__/swagger-with-invalid-extensions.json', '--key', key, '--version', version]),
       ).rejects.toThrow(new APIError(errorObject));
 
       return mock.done();

src/cmds/openapi/convert.ts

@@ -9,6 +9,7 @@ import prompts from 'prompts';
 
 import BaseCommand from '../../lib/baseCommand.js';
 import { workingDirectoryFlag } from '../../lib/flags.js';
+import { warn } from '../../lib/logger.js';
 import prepareOas from '../../lib/prepareOas.js';
 import promptTerminal from '../../lib/promptWrapper.js';
 import { validateFilePath } from '../../lib/validatePromptInput.js';
@@ -39,7 +40,7 @@ export default class OpenAPIConvertCommand extends BaseCommand<typeof OpenAPICon
     const parsedPreparedSpec: OASDocument = JSON.parse(preparedSpec);
 
     if (specType === 'OpenAPI') {
-      this.warn(
+      warn(
         'The input file is already OpenAPI, so no conversion is necessary. Any external references will be bundled.',
       );
     }