Use single method to open/close flyout #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agjohnson
reviewed
Feb 19, 2025
| }; | ||
|
|
||
| _hideFlyout = (e) => { | ||
| this.opened = false; | ||
| this._close(); |
There was a problem hiding this comment.
Lit provides a native way to update dependent attributes/variables on reactive property changes. We should use that pattern instead of relying on manually calling methods like this. With willUpdate(), the current code would be fine
humitos
reviewed
Feb 19, 2025
|
Cool... I'm a little lost in general with all of this, so might take a while to get back to this. |
|
@ericholscher let me know if I can help here or if you want me to take over it. |
|
Feel free to run with it. It was just a small bug I wanted to fix, but the PR feedback seems to require a ton of research that I don't have energy for currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #541