Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications: use heiristic to add the notification inline #550

Open
humitos opened this issue Feb 20, 2025 · 0 comments · May be fixed by #552
Open

Notifications: use heiristic to add the notification inline #550

humitos opened this issue Feb 20, 2025 · 0 comments · May be fixed by #552

Comments

@humitos
Copy link
Member

humitos commented Feb 20, 2025

We should be able to DocumentationTool class to detect what's the HTML generator and use specific CSS selectors to inject the notification in the document with inline-block position so it doesn't cover any content.

Image
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Feb 20, 2025
humitos added a commit that referenced this issue Feb 20, 2025
@humitos
Notification: render it inline using docTool.getRootSelector()
398478a 
Instead of rendering the notification floating at the top right, we use the
heuristic from `DocumentationTool` class to get the root selector and we prepend
the notification WebComponent there.

Closes #550
@humitos humitos linked a pull request Feb 20, 2025 that will close this issue
Open
4 tasks
@humitos humitos moved this from Planned to In progress in 📍Roadmap Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
📍Roadmap
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Notification: render it inline using docTool.getRootSelector() readthedocs/addons
1 participant
@humitos