Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications: default behavior for PR versions #557

Open
humitos opened this issue Feb 24, 2025 · 0 comments
Open

Notifications: default behavior for PR versions #557

humitos opened this issue Feb 24, 2025 · 0 comments

Comments

@humitos
Copy link
Member

humitos commented Feb 24, 2025

We've talked about what would be a good default behavior for notifications on pull requests (external versions):

  • I (humitos) think the current behavior is fine (enabled by default) and it doesn't bother me too much
  • Eric mentioned he wants it to be disabled by default

I'm not super strict here tho. In particular, because we already have some other UI elements (file tree diff) that also "communicates" in a not-too-clear-way tho, that this is not the production version.

If we want to move forward with Eric's proposal we need to define how to change the current default state, since all the projects have it already enabled. Would we change this behavior only for new projects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Planned
Development

No branches or pull requests

1 participant