Conditionally load advertising manually #35
Conversation
By setting ``data-ea-manual``, you can set ads to load manually. After that you can call ``ethicalads.load()`` to load them.
| * | ||
| * <div data-ea-publisher="..." data-ea-manual="true"></div> | ||
| * <script> | ||
| * ethicalads.load(); |
There was a problem hiding this comment.
Does this allow us to set keywords on the request? That seems important since we don't have that data prior?
There was a problem hiding this comment.
We could probably make it accept options but it doesn't currently. You can still attach the keywords to the div the normal way.
There was a problem hiding this comment.
Right, but I thought the point of this PR was to use it on RTD, where we don't know the keywords until we get the API response?
There was a problem hiding this comment.
My plan was to add/modify that DOM element after the API response.
There was a problem hiding this comment.
I'll test this out and see how well it works. Maybe we do need additional options to load().
|
@davidfischer should we merge this to go out with the default client? |
By setting
data-ea-manual, you can set ads to load manually. After that you can callethicalads.load()to load them. This can't be used to load a new ad (eg. #24) and it will error out if it attempts to load a new ad.