Don't use signal

Author: stsewd

readthedocs/builds/signals_receivers.py

@@ -22,21 +22,3 @@ def update_latest_build_for_project(sender, instance, created, **kwargs):
         Project.objects.filter(pk=instance.project_id).update(
             latest_build=instance,
         )
-
-
-# TODO: this should be moved to an API call done after the build is completed.
-@receiver(post_save, sender=Build)
-def update_is_uploaded_for_version(sender, instance, created, **kwargs):
-    """
-    When a successful build via the upload API is completed, update the version.
-
-    .. note::
-
-       This isn't 100% accurate, as an old build could be saved again,
-       and the version would be marked as uploaded even if the latest build isn't uploaded.
-    """
-    build = instance
-    if build.version and build.finished and build.success and build.is_uploaded:
-        version = instance.version
-        version.is_uploaded = True
-        version.save(update_fields=["is_uploaded"])

readthedocs/builds/tasks.py

@@ -798,6 +798,11 @@ def run_post_build_tasks(build_pk):
     )
 
     if build.success:
+        if build.is_uploaded and build.version:
+            version = build.version
+            version.is_uploaded = True
+            version.save(update_fields=["is_uploaded"])
+
         index_build.delay(build_id=build.pk)
 
         if "readthedocsext.spamfighting" in settings.INSTALLED_APPS: