Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make links with tooltip visually different #11

Closed
humitos opened this issue Aug 19, 2019 · 7 comments
Closed

Make links with tooltip visually different #11

humitos opened this issue Aug 19, 2019 · 7 comments
Labels
Design Design or UX/UI related Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Aug 19, 2019

It would be good to make these links visually different from a regular link that won't show a tooltip.

It may be a small icon, or maybe some CSS style.

I was thinking on using the same style as :abbr:, that adds a small dotted border at the bottom as the first approach.

Screenshot_2019-08-19_21-19-30

@humitos
Copy link
Member Author

humitos commented Aug 19, 2019

Small border,

.hoverxref {
  border-bottom: 1px dotted;
}

Using an icon,

.hoverxref:after {
  content: " \f05a";
  font-family: FontAwesome;
  top: -5px;
  position: relative;
  font-size: 70%;
}

@humitos
Copy link
Member Author

humitos commented Aug 20, 2019

Some initial work was done at 67f30ed

It can be improved, though.

@humitos humitos added Improvement Minor improvement to code Design Design or UX/UI related labels Aug 20, 2019
@humitos
Copy link
Member Author

humitos commented Apr 4, 2020

Screenshot_2020-04-04_16-58-42

@humitos
Copy link
Member Author

humitos commented Apr 4, 2020

  content: " \f05a";

content: " \f0eb";, using a light bulb looks nicer: https://fontawesome.com/icons/lightbulb

Screenshot_2020-04-04_17-07-04

@humitos
Copy link
Member Author

humitos commented Aug 31, 2020

I think the current behavior is fine for now and there is nothing we should do at this point. Users can always extend the CSS to customize the look & feel. We haven't receive any complain about how it looks yet, so I'd say it's fine for now and we can close this issue.

@maxmahlke
Copy link

I just spent some time adapting the appearance of the tooltip-links. Note that compared to @humitos CSS snippet above, I had to adapt the name of the hoverxref object to hxr-hoverxref. I succeeded by putting the following into the custom.css file:

.hxr-hoverxref {
  border-bottom: 0px;
  color: LightCoral;
}

@benjaoming
Copy link
Contributor

Thanks @maxmahlke !

There are many Sphinx extensions that add new objects to the DOM with a special meaning. It should be up to the themes to add further visual styling on top of a styling that the extension defines. It's also up to the themes to decide which extensions are popular enough.

If there are more cool ideas, such as the light bulb icon, I think that we could add extra styling in sphinx_rtd_theme (for instance in a separate extensions.scss).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design or UX/UI related Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants