Hotfix/fix core settings (#123)

### Fixed
- issue where order of operations caused scriptable object creation errors

Author: HarrisonHough

.github/latest.md

@@ -2,6 +2,4 @@
 ## Changelog
 
 ### Fixed
-- an issue with module installer causing errors when importing on some Windows machines by @rYuuk in [#117](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/117)
-
-
+- an issue causing settings to be recreated when not needed @harrisonhough in [#123](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/123)

CHANGELOG.md

@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [3.2.3] - 2023.09.11
+### Fixed
+- an issue causing settings to be recreated when not needed @harrisonhough in [#123](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/123)
+
 ## [3.2.2] - 2023.09.07
 
 ### Fixed

Editor/BuildPostProcessor.cs

@@ -11,10 +11,7 @@ public static class BuildPostProcessor
         public static void OnPostprocessBuild(BuildTarget target, string pathToBuiltProject)
         {
             // create asset if it has been deleted
-            if (CoreSettingsHandler.CoreSettings == null)
-            {
-                CoreSettingsHandler.CreateCoreSettings();
-            }
+            CoreSettingsHandler.EnsureSettingsExist();
             AppData appData = ApplicationData.GetData();
             AnalyticsEditorLogger.EventLogger.LogBuildApplication(appData.BuildTarget, PlayerSettings.productName, !Debug.isDebugBuild);
         }

Editor/Module Management/ModuleInstaller.cs

@@ -61,8 +61,8 @@ static ModuleInstaller()
 
         private static void DelayCreateCoreSettings()
         {
-            CoreSettingsHandler.CreateCoreSettings();
             EditorApplication.delayCall -= DelayCreateCoreSettings;
+            CoreSettingsHandler.EnsureSettingsExist();
         }
 
         /// <summary>

README.md

@@ -92,7 +92,7 @@ After the process is complete you project will have imported these packages:
         }
      ],
      "dependencies": {
-        "com.readyplayerme.core": "3.2.2"
+        "com.readyplayerme.core": "3.2.3"
        }
      }
      ```

Runtime/CoreSettingsHandler.cs

@@ -14,16 +14,14 @@ public static CoreSettings CoreSettings
         {
             get
             {
+                if (coreSettings != null) return coreSettings;
+                coreSettings = Resources.Load<CoreSettings>(RESOURCE_PATH);
+#if UNITY_EDITOR
                 if (coreSettings == null)
                 {
-                    coreSettings = Resources.Load<CoreSettings>(RESOURCE_PATH);
-#if UNITY_EDITOR
-                    if (coreSettings == null)
-                    {
-                        coreSettings = CreateCoreSettings();
-                    }
-#endif
+                    coreSettings = CreateSettings();
                 }
+#endif
                 return coreSettings;
             }
         }
@@ -49,7 +47,16 @@ public static void Save()
             AssetDatabase.SaveAssets();
         }
 
-        public static CoreSettings CreateCoreSettings()
+        public static void EnsureSettingsExist()
+        {
+            coreSettings = Resources.Load<CoreSettings>(RESOURCE_PATH);
+            if (coreSettings == null)
+            {
+                coreSettings = CreateSettings();
+            }
+        }
+
+        private static CoreSettings CreateSettings()
         {
             DirectoryUtility.ValidateDirectory($"{Application.dataPath}/{SETTINGS_SAVE_FOLDER}");
             var newSettings = ScriptableObject.CreateInstance<CoreSettings>();

Runtime/Data/ApplicationData.cs

@@ -6,7 +6,7 @@ namespace ReadyPlayerMe.Core
 {
     public static class ApplicationData
     {
-        private const string SDK_VERSION = "v3.2.2";
+        private const string SDK_VERSION = "v3.2.3";
         private const string TAG = "ApplicationData";
         private const string DEFAULT_RENDER_PIPELINE = "Built-In Render Pipeline";
         private static readonly AppData Data;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "com.readyplayerme.core",
-  "version": "3.2.2",
+  "version": "3.2.3",
   "displayName": "Ready Player Me Core",
   "description": "This Module contains all the core functionality required for using Ready Player Me avatars in Unity, including features such as: \n - Module management and automatic package setup logic\n - Avatar loading from .glb files\n - Avatar and 2D render requests\n - Optional Analytics\n - Custom editor windows\n - Sample scenes and assets",
   "unity": "2020.3",