Skip to content

Commit 9d654a7

Browse files
committed
chore: apply suggestions
1 parent d15db85 commit 9d654a7

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

Runtime/AvatarCreator/Scripts/UI/Elements/TemplateSelectionElement.cs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ public class TemplateSelectionElement : SelectionElement
1717
{
1818
private const string TAG = nameof(TemplateSelectionElement);
1919
[SerializeField] private TemplateVersions templateVersions = TemplateVersions.V2;
20-
public OutfitGender gender = OutfitGender.None;
2120
private List<AvatarTemplateData> avatarTemplates;
2221
private AvatarTemplateFetcher avatarTemplateFetcher;
2322
private CancellationToken ctx;
@@ -30,27 +29,26 @@ private void Awake()
3029
avatarTemplateFetcher = new AvatarTemplateFetcher(ctx);
3130
}
3231

32+
3333
/// <summary>
3434
/// Asynchronously loads avatar template data and creates button elements for each template.
3535
/// Each button is created with an icon fetched from the template's image URL.
3636
/// </summary>
3737
public async void LoadAndCreateButtons()
3838
{
39-
await LoadAndCreateButtons(false);
39+
await LoadAndCreateButtons(OutfitGender.None);
4040
}
4141

4242
/// <summary>
43-
/// Asynchronously loads avatar template data and creates button elements for each template.
43+
/// Asynchronously loads avatar template data and creates button elements for each template based on the gender.
4444
/// Each button is created with an icon fetched from the template's image URL.
45+
/// <param name="gender">Gender for which the templates are loaded for</param>
4546
/// </summary>
46-
public async Task LoadAndCreateButtons(bool useCachedResponse)
47+
public async Task LoadAndCreateButtons(OutfitGender gender)
4748
{
48-
if (!useCachedResponse || avatarTemplates == null)
49-
{
50-
await LoadTemplateData();
51-
}
49+
await LoadTemplateData();
5250

53-
var filteredTemplates = avatarTemplates!.Where(template => HasCorrectTemplateVersion(template) && HasCorrectGender(template)).ToList();
51+
var filteredTemplates = avatarTemplates!.Where(template => HasCorrectTemplateVersion(template) && HasCorrectGender(template, gender)).ToList();
5452

5553
CreateButtons(filteredTemplates!.ToArray(), async (button, asset) =>
5654
{
@@ -75,7 +73,7 @@ private bool HasCorrectTemplateVersion(AvatarTemplateData template)
7573
}
7674
}
7775

78-
private bool HasCorrectGender(AvatarTemplateData template)
76+
private bool HasCorrectGender(AvatarTemplateData template, OutfitGender gender)
7977
{
8078
if (gender == OutfitGender.None || template.Gender == OutfitGender.None)
8179
{

0 commit comments

Comments
 (0)