Skip to content

Commit fa64900

Browse files
committed
Merge branch 'hotfix/v6.2.3' into develop
2 parents 781bb4e + d794929 commit fa64900

File tree

5 files changed

+18
-19
lines changed

5 files changed

+18
-19
lines changed

Diff for: .github/latest.md

+1-6
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11

22
## Changelog
33

4-
### Updated
5-
6-
- Updated XR template avatar to have separated head mesh [#261](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/261)
7-
- Improved GetMeshRenderer() method to exclude invalid mesh renderers [#261](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/261)
8-
94
### Fixed
105

11-
- Fixed issue with XR animation avatars
6+
- reverted update to GetMeshRenderer method [#264](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/264)

Diff for: CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@
33
All notable changes to this project will be documented in this file.
44
This project adheres to [Semantic Versioning](http://semver.org/).
55

6+
## [6.2.3] - 2024.04.29
7+
8+
### Fixed
9+
10+
- reverted update to GetMeshRenderer method [#264](https://github.com/readyplayerme/rpm-unity-sdk-core/pull/264)
11+
612
## [6.2.2] - 2024.04.29
713

814
### Updated

Diff for: Runtime/Core/Scripts/Data/ApplicationData.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace ReadyPlayerMe.Core
66
{
77
public static class ApplicationData
88
{
9-
public const string SDK_VERSION = "v6.2.2";
9+
public const string SDK_VERSION = "v6.2.3";
1010
private const string TAG = "ApplicationData";
1111
private const string DEFAULT_RENDER_PIPELINE = "Built-In Render Pipeline";
1212
private static readonly AppData Data;

Diff for: Runtime/Core/Scripts/Extensions/ExtensionMethods.cs

+9-11
Original file line numberDiff line numberDiff line change
@@ -59,34 +59,32 @@ public static void SaveToFile(this AvatarMetadata metadata, string guid, string
5959
/// <returns>The <see cref="SkinnedMeshRenderer" /> if found.</returns>
6060
public static SkinnedMeshRenderer GetMeshRenderer(this GameObject gameObject, MeshType meshType)
6161
{
62-
SkinnedMeshRenderer meshRenderer;
63-
var childMeshes = gameObject.GetComponentsInChildren<SkinnedMeshRenderer>()
64-
.Where(mesh => mesh.sharedMesh != null) // Filter out any SkinnedMeshRenderer with no mesh
65-
.ToArray();
66-
if (childMeshes.Length == 0)
62+
SkinnedMeshRenderer mesh;
63+
List<SkinnedMeshRenderer> children = gameObject.GetComponentsInChildren<SkinnedMeshRenderer>().ToList();
64+
65+
if (children.Count == 0)
6766
{
6867

6968
SDKLogger.AvatarLoaderLogger.Log(TAG, $"No SkinnedMeshRenderer found on the Game Object {gameObject.name}.");
7069
return null;
7170
}
72-
73-
71+
7472
switch (meshType)
7573
{
7674
case MeshType.BeardMesh:
77-
meshRenderer = childMeshes.FirstOrDefault(child => BEARD_MESH_NAME_FILTER == child.name);
75+
mesh = children.FirstOrDefault(child => BEARD_MESH_NAME_FILTER == child.name);
7876
break;
7977
case MeshType.TeethMesh:
80-
meshRenderer = childMeshes.FirstOrDefault(child => TEETH_MESH_NAME_FILTER == child.name);
78+
mesh = children.FirstOrDefault(child => TEETH_MESH_NAME_FILTER == child.name);
8179
break;
8280
case MeshType.HeadMesh:
83-
meshRenderer = childMeshes.FirstOrDefault(child => HeadMeshNameFilter.Contains(child.name));
81+
mesh = children.FirstOrDefault(child => HeadMeshNameFilter.Contains(child.name));
8482
break;
8583
default:
8684
throw new ArgumentOutOfRangeException(nameof(meshType), meshType, null);
8785
}
8886

89-
if (meshRenderer != null) return meshRenderer;
87+
if (mesh != null) return mesh;
9088

9189
SDKLogger.AvatarLoaderLogger.Log(TAG, $"Mesh type {meshType} not found on the Game Object {gameObject.name}.");
9290

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "com.readyplayerme.core",
3-
"version": "6.2.2",
3+
"version": "6.2.3",
44
"displayName": "Ready Player Me Core",
55
"description": "This Module contains all the core functionality required for using Ready Player Me avatars in Unity, including features such as: \n - Module management and automatic package setup logic\n - Avatar loading from .glb files \n - Avatar creation \n - Avatar and 2D render requests \n - Optional Analytics\n - Custom editor windows\n - Sample scenes and assets",
66
"unity": "2020.3",

0 commit comments

Comments
 (0)