refactor(lint): fix .eslintrc

Author: koichik

.eslintrc

@@ -1,5 +1,5 @@
 {
-  "extend": "eslint-config-airbnb",
+  "extends": "eslint-config-airbnb",
 
   "parserOptions": {
     "ecmaVersion": 6,
@@ -20,60 +20,82 @@
 
   "plugins": [
     "import",
-    "react"
+    "react",
+    "dependencies"
   ],
 
+  "globals": {
+    "__CLIENT__": true,
+    "__SERVER__": true,
+    "__DEVELOPMENT__": true,
+    "__DISABLE_SSR__": true
+  },
+
   "rules": {
     //Possible Errors
     "no-console": "error",
     "no-unexpected-multiline": "error",
 
     // Best Practices
+    "class-methods-use-this": "off",
+    "consistent-return": ["error", { "treatUndefinedAsUnspecified": true }],
     "dot-location": ["error", "property"],
     "no-implicit-globals": "error",
     "no-invalid-this": "error",
+    "no-param-reassign": ["error", { "props": false }],
     "no-unmodified-loop-condition": "error",
     "no-useless-call": "error",
+    "no-void": "off",
 
     // Variables
     "no-catch-shadow": "error",
     "no-label-var": "error",
+    "no-shadow": ["error", { "allow": ["cb", "next", "req", "res", "err", "error"] }],
     "no-undef-init": "error",
     "no-undefined": "error",
     "no-use-before-define": ["error", "nofunc"],
+    "no-unused-expressions": ["error", { "allowShortCircuit": true }],
+    "no-unused-vars": ["error", { "args": "none" }],
 
     // Node.js
     "callback-return": "error",
     "no-path-concat": "error",
 
     // Stylistic Issues
+    "comma-dangle": ["error", "always-multiline"],
     "linebreak-style": ["error", "unix"],
+    "no-plusplus": "off",
 
     // ECMAScript 6
-    "arrow-parens": "error",
+    "arrow-parens": ["error", "always"],
     "constructor-super": "error",
     "generator-star-spacing": ["error", "after"],
     "no-this-before-super": "error",
+    "prefer-arrow-callback": ["error", { "allowNamedFunctions": true }],
     "prefer-spread": "error",
+    "prefer-template": "off",
 
     // React
+    "react/forbid-prop-types": "off",
     "react/no-danger": "error",
-    "react/no-deprecated": "error",
-    "react/no-did-mount-set-state": "error",
-    "react/no-did-update-set-state": "error",
     "react/no-direct-mutation-state": "error",
-    "react/no-is-mounted": "error",
     "react/no-set-state": "error",
-    "react/no-string-refs": "error",
-    "react/require-extension": ["error", {"extensions": [".js", ".jsx"]}],
-    "react/wrap-multilines": "error",
+    "react/no-unused-prop-types": "off",
+    "react/prefer-stateless-function": "off",
+    "react/prop-types": "off",
+    "react/self-closing-comp": "off",
 
     // JSX
-    "react/jsx-equals-spacing": "error",
-    "react/jsx-indent": ["error", 2],
+    "react/jsx-filename-extension": ["error", { "extensions": [".js", ".jsx"] }],
     "react/jsx-key": "error",
     "react/jsx-max-props-per-line": ["error", {"maximum": 3}],
-    "react/jsx-no-duplicate-props": "error",
-    "react/jsx-space-before-closing": "error"
+
+    // dependencies
+    "dependencies/case-sensitive": "error",
+    "dependencies/no-cycles": "error",
+    "dependencies/no-unresolved": "error",
+
+    // coding styles
+    "max-len": ["error", 100]
   }
 }

src/ReduxAsyncLoaderContext.js

@@ -7,7 +7,7 @@
  *   https://github.com/ryanflorence/async-props/blob/master/LICENSE.md
  */
 
-import React, { Component } from 'react';
+import { Component } from 'react';
 import PropTypes from 'prop-types';
 import computeChangedRoutes from './computeChangedRoutes';
 import { beginAsyncLoad, endAsyncLoad, skipAsyncLoad } from './actions';

src/computeChangedRoutes.js

@@ -15,7 +15,6 @@ export default function computeChangedRoutes(prevState, nextState) {
     return nextRoutes;
   }
 
-  let parentIsLeaving = false;
   const leaveIndex = prevRoutes.findIndex((route) => (
     nextRoutes.indexOf(route) === -1 ||
     routeParamsChanged(route, prevState, nextState) ||
@@ -24,7 +23,7 @@ export default function computeChangedRoutes(prevState, nextState) {
   ));
   const leaveRoutes = leaveIndex === -1 ? [] : prevRoutes.slice(leaveIndex);
 
-  return nextRoutes.filter(function (route) {
+  return nextRoutes.filter((route) => {
     const isNew = prevRoutes.indexOf(route) === -1;
     const paramsChanged = leaveRoutes.indexOf(route) !== -1;
 
@@ -45,7 +44,7 @@ function routeParamsChanged(route, prevState, nextState) {
 }
 
 function queryParamsChanged(route, prevState, nextState) {
-  const queryKeys = route.asyncLoaderProps && route.asyncLoaderProps.queryKeys || route.queryKeys;
+  const queryKeys = (route.asyncLoaderProps && route.asyncLoaderProps.queryKeys) || route.queryKeys;
   if (!queryKeys) {
     return false;
   }
@@ -66,6 +65,6 @@ function queryParamsChanged(route, prevState, nextState) {
 }
 
 function routeChanged(route, prevState, nextState) {
-  const routeChanged = route.asyncLoaderProps && route.asyncLoaderProps.routeChanged;
-  return routeChanged && routeChanged(route, prevState, nextState);
+  const changed = route.asyncLoaderProps && route.asyncLoaderProps.routeChanged;
+  return changed && changed(route, prevState, nextState);
 }

src/deferLoader.js

@@ -1,4 +1,4 @@
-import React, { Component, cloneElement } from 'react';
+import React, { Component } from 'react';
 import PropTypes from 'prop-types';
 import hoistStatics from 'hoist-non-react-statics';
 
@@ -30,6 +30,6 @@ export default function deferLoader(loader) {
   };
 }
 
-function getDisplayName(Component) {
-  return Component.displayName || Component.name;
+function getDisplayName(component) {
+  return component.displayName || component.name;
 }

src/flattenComponents.js

@@ -8,24 +8,22 @@
 import { loadAsyncPropertyName } from './names';
 
 // based on https://github.com/ryanflorence/async-props/blob/v0.3.2/modules/AsyncProps.js#L8-L18
-function eachComponents(components, iterator) {
+function eachComponents(components, cb) {
   for (let i = 0, l = components.length; i < l; i++) {
     const component = components[i];
     if (typeof component === 'object') {
       // named components
       // https://github.com/reactjs/react-router/blob/master/docs/API.md#named-components
-      for (let key of Object.keys(component)) {
-        iterator(component[key], i, key);
-      }
+      Object.keys(component).forEach((key) => cb(component[key], i, key));
     } else {
-      iterator(component, i);
+      cb(component, i); // eslint-disable-line callback-return
     }
   }
 }
 
 // based on https://github.com/ryanflorence/async-props/blob/v0.3.2/modules/AsyncProps.js#L20-L27
 export default function flattenComponents(components) {
-  var flattened = [];
+  const flattened = [];
   eachComponents(components, (Component) => {
     if (Component && Component[loadAsyncPropertyName]) {
       flattened.push(Component);