Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noobaa ns interpretation #224

Open
black-dragon74 opened this issue Feb 4, 2025 · 0 comments
Open

Fix noobaa ns interpretation #224

black-dragon74 opened this issue Feb 4, 2025 · 0 comments
Assignees

Comments

@black-dragon74
Copy link
Member

Lines 68 and 77 needs updating as well (maybe moved into for block)?

for pod in $(oc -n "${ns}" get pods -l "${NOOBAA_POSTGRES_LABEL}" | grep -v NAME | awk '{print $1}'); do

NOOBAA_RECONCILE_STRATEGY=$(oc -n "${ns}" get storagecluster -o jsonpath='{.items[0].spec.multiCloudGateway.reconcileStrategy}' 2>/dev/null)

What is the value of ns supposed to be here? Was it wrongly interpreted all this time?

P.S: The INSTALL_NAMESPACE changes LGTM. Just pointing out what I stumbled across while reviewing.

Regards

Originally posted by @black-dragon74 in #218 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants