Add support for signing with Sigstore #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm currently testing this change in this repo: https://github.com/travier/cosign-test This needs a newer podman version than the one currently available in Ubuntu 22.04 ( |
🤔 Filed as containers/podman#20771. |
|
I now have a working setup with https://github.com/travier/podman-action & https://github.com/travier/cosign-test which works with this PR. Example multi-arch, podman signed build in https://github.com/travier/cosign-test/blob/main/.github/workflows/nginx.yml. |
|
This should work once the Ubuntu 24.04 runner images become the default. |
travier
force-pushed
the
sigstore-signing
branch
from
d5ebbdb to
69b4e0b
Compare
|
I've rebased this PR which should now be ready as the Ubuntu 24.04 runners have a recent enough podman version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for signing with Sigstore
Related Issue(s)
Fixes: #89
Checklist
Changes made
README: Fix Markdown lints and typos
Add support for signing with Sigstore
Fixes: #89
Update node dependencies: npm audit fix --force
Update bundle: rpm run bundle