fix: Add missing impersonate rule (#845)

* Add missing permission in clusterrole

Signed-off-by: Varsha B <[email protected]>

* test change

Signed-off-by: Varsha B <[email protected]>

---------

Signed-off-by: Varsha B <[email protected]>

Author: varshab1210

controllers/argocd/openshift/openshift.go

@@ -333,6 +333,17 @@ func policyRulesForClusterConfig() []rbacv1.PolicyRule {
 				"*",
 			},
 		},
+		{
+			APIGroups: []string{
+				"",
+			},
+			Resources: []string{
+				"serviceaccounts",
+			},
+			Verbs: []string{
+				"impersonate",
+			},
+		},
 	}
 }
 

controllers/argocd/openshift/openshift_test.go

@@ -45,8 +45,7 @@ func TestReconcileArgoCD_reconcileMultipleClusterRoles(t *testing.T) {
 	a := makeTestArgoCDForClusterConfig()
 	testApplicableClusterRole := &rbacv1.ClusterRole{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      a.Name + "-" + a.Namespace + "-" + testApplicationController,
-			Namespace: a.Namespace,
+			Name: a.Name + "-" + a.Namespace + "-" + testApplicationController,
 		},
 		Rules: makeTestPolicyRules(),
 	}