Skip to content

build: verifyPlugin fails on verify plugin 1.385 #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adietish opened this issue May 12, 2025 · 4 comments · Fixed by #873 or #895
Closed

build: verifyPlugin fails on verify plugin 1.385 #872

adietish opened this issue May 12, 2025 · 4 comments · Fixed by #873 or #895
Assignees
@adietish @sbouchet

Comments

@adietish
Copy link
Collaborator

adietish commented May 12, 2025 •
edited
Loading

Reported to jebrains: https://youtrack.jetbrains.com/issue/MP-7480/

Steps:

  1. EXEC: launch plugin verifier (latest version is currently 1.385, marketplace is using prior version 1.383)
./gradlew clean verifyPlugin

Result:
Verification fails

Compatibility problems (2):

    #Invocation of unresolved constructor com.intellij.diff.actions.impl.MutableDiffRequestChain.<init>(DiffContent, DiffContent, Project)
        Method com.redhat.devtools.intellij.kubernetes.editor.ResourceDiff.createDiffRequestChain(com.intellij.openapi.vfs.VirtualFile file, java.lang.String toCompare) : com.intellij.diff.actions.impl.MutableDiffRequestChain contains an *invokespecial* instruction referencing an unresolved constructor com.intellij.diff.actions.impl.MutableDiffRequestChain.<init>(com.intellij.diff.contents.DiffContent, com.intellij.diff.contents.DiffContent, com.intellij.openapi.project.Project). This can lead to **NoSuchMethodError** exception at runtime.

    #Invocation of unresolved method com.intellij.openapi.components.ServicesKt.serviceNotFoundError(ComponentManager, Class) : IllegalStateException
        Method com.redhat.devtools.intellij.kubernetes.settings.Settings.Companion.getInstance() : com.redhat.devtools.intellij.kubernetes.settings.Settings contains an *invokestatic* instruction referencing an unresolved method com.intellij.openapi.components.ServicesKt.serviceNotFoundError(com.intellij.openapi.components.ComponentManager, java.lang.Class) : java.lang.IllegalStateException. This can lead to **NoSuchMethodError** exception at runtime.
Compatibility problems (1): 
    #Package 'com.redhat.devtools.intellij.telemetry' is not found
        Package 'com.redhat.devtools.intellij.telemetry' is not found along with its 2 classes.
        Probably the package 'com.redhat.devtools.intellij.telemetry' belongs to a library or dependency that is not resolved by the checker.
        It is also possible, however, that this package was actually removed from a dependency causing the detected problems. Access to unresolved classes at runtime may lead to **NoSuchClassError**.
Compatibility problems (1): 
    #Package 'com.redhat.devtools.intellij.telemetry' is not found
        Package 'com.redhat.devtools.intellij.telemetry' is not found along with its 2 classes.
        Probably the package 'com.redhat.devtools.intellij.telemetry' belongs to a library or dependency that is not resolved by the checker.
        It is also possible, however, that this package was actually removed from a dependency causing the detected problems. Access to unresolved classes at runtime may lead to **NoSuchClassError**.
        The following classes of 'com.redhat.devtools.intellij.telemetry' are not resolved:
          Class com.redhat.devtools.intellij.telemetry.core.service.TelemetryMessageBuilder.ActionMessage is referenced in
            com.redhat.devtools.intellij.kubernetes.actions.ScaleReplicaAction.aborting(String cause, TelemetryMessageBuilder.ActionMessage telemetry) : void
            com.redhat.devtools.intellij.kubernetes.actions.SetAsCurrentClusterAction.actionPerformed$lambda$0(SetAsCurrentClusterAction this$0, IContext $context, TelemetryMessageBuilder.ActionMessage $telemetry, ProgressIndicator it) : void
            com.redhat.devtools.intellij.kubernetes.actions.TerminalAction.actionPerformed$lambda$2(List $pods, TerminalAction this$0, IResourceModel $model, Project $project, ProgressIndicator it) : void
            com.redhat.devtools.intellij.kubernetes.editor.actions.PushAllAction.actionPerformed$lambda$0(FileEditor $editor, Project $project, TelemetryMessageBuilder.ActionMessage $telemetry, ProgressIndicator it) : void
            com.redhat.devtools.intellij.kubernetes.editor.actions.PushModifiedAction.actionPerformed$lambda$0(FileEditor $editor, Project $project, TelemetryMessageBuilder.ActionMessage $telemetry, ProgressIndicator it) : void
            ...and 40 other places...
          Class com.redhat.devtools.intellij.telemetry.core.service.TelemetryMessageBuilder is referenced in
            com.redhat.devtools.intellij.kubernetes.actions.OpenDashboardAction.actionPerformed$lambda$0(IActiveContext $currentContext, ProgressIndicator it) : void
            com.redhat.devtools.intellij.kubernetes.actions.SetCurrentProjectAction.onOk$lambda$4$lambda$3(IResourceModel $model, String $name, ProgressIndicator it) : void
            com.redhat.devtools.intellij.kubernetes.actions.UseProjectAction.actionPerformed(AnActionEvent event, TreePath path, Object selectedNode) : void
            com.redhat.devtools.intellij.kubernetes.editor.actions.PullAction.actionPerformed(AnActionEvent e) : void
            com.redhat.devtools.intellij.kubernetes.editor.actions.PushModifiedAction.actionPerformed(AnActionEvent e) : void
            ...and 19 other places...

This makes all our PRs fail.

See https://github.com/redhat-developer/intellij-kubernetes/actions/runs/14709415219/job/41949522399#step:7:645
@adietish adietish self-assigned this May 12, 2025
@adietish adietish moved this to 📝 In Progress in IDE Cloudaptors May 12, 2025
adietish added a commit to adietish/intellij-kubernetes that referenced this issue May 12, 2025
@adietish
chore(skip-release): use SimpleDiffRequest to fix verifier complaint (r…
dfe5487 
…edhat-developer#872)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish adietish mentioned this issue May 12, 2025
Merged
adietish added a commit to adietish/intellij-kubernetes that referenced this issue May 12, 2025
@adietish
chore(skip-release): catch service not found to fix verifier complaint (
516455f 
redhat-developer#872)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue May 12, 2025
@adietish
chore(skip-release): catch service not found to fix verifier complaint (
54b161c 
redhat-developer#872)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit to adietish/intellij-kubernetes that referenced this issue May 12, 2025
@adietish
chore(skip-release): catch service not found to fix verifier complaint (
fef0ab7 
redhat-developer#872)

Signed-off-by: Andre Dietisheim <[email protected]>
@adietish
Copy link
Collaborator Author

I tried to force the verification to be run with the prior version 1.383 but none of my attemps was successful. I tried setting

intellijPlatform {
    pluginVerification {
        version = "1.383"
    }
}

but to no avail. Setting the dependency version didn't work either:

implementation("org.jetbrains:verifier-cli:1.314")

@adietish adietish moved this from 📝 In Progress to 👀 In review in IDE Cloudaptors May 13, 2025
@adietish
Copy link
Collaborator Author

adietish commented May 14, 2025 •
edited
Loading

#873 fixed the 2 issues but could address the missing dependency of intellij-redhat-telemetry which is a bug in plugin verifier 1.385
We therefore disabled the verification for now, waiting for a new and fixed version of the plugin verifier to be released.

adietish added a commit that referenced this issue May 15, 2025
@adietish
chore(skip-release): use SimpleDiffRequest to fix verifier complaint (#…
a86a320 
…872)

Signed-off-by: Andre Dietisheim <[email protected]>
adietish added a commit that referenced this issue May 15, 2025
@adietish
chore(skip-release): catch service not found to fix verifier complaint (
e82f61c 
#872)

Signed-off-by: Andre Dietisheim <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors May 15, 2025
@adietish
Copy link
Collaborator Author

Reopening to track the state of the plugin verifier. Crossing fingers the next version of the plugin verifier does not fail any more.

@adietish adietish reopened this May 15, 2025
@sbouchet
Copy link
Collaborator

still fails with 1.386. let's wait for next one ...
also, marketplace started to use 1.385 so our extension verification now fails there too.

@sbouchet sbouchet self-assigned this Jun 5, 2025
@sbouchet sbouchet moved this from ✅ Done to 👀 In review in IDE Cloudaptors Jun 5, 2025
@sbouchet sbouchet linked a pull request Jun 5, 2025 that will close this issue
chore: use an older version of pluginVerifier #895
Merged
@adietish adietish moved this from 👀 In review to 📋 Backlog in IDE Cloudaptors Jun 10, 2025
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in IDE Cloudaptors Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adietish adietish

@sbouchet sbouchet

Labels
None yet
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
No milestone
2 participants
@adietish @sbouchet