fix: only use 1st cfg file when logging in, dont add all ctxts (#966) #971
Conversation
|
Skipping CI for Draft Pull Request. |
adietish
force-pushed
the
issue-966
branch
4 times, most recently
from
700ba6c to
2574f13
Compare
| @@ -11,7 +11,7 @@ gradleVersion=8.5 | |||
|
|
|||
| # Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html | |||
| platformBundledPlugins=com.intellij.java, org.jetbrains.plugins.yaml, org.jetbrains.plugins.terminal | |||
| platformPlugins=com.redhat.devtools.intellij.telemetry:1.2.1.62, com.redhat.devtools.intellij.kubernetes:1.4.0.4 | |||
| platformPlugins=com.redhat.devtools.intellij.telemetry:1.2.1.62 | |||
There was a problem hiding this comment.
there's no dependency of openshift to kubernetes. The only thing that we may want is that people would install kubernetes plugin when installing the openshift plugin. We need to remove the kubernetes plugin 1.4 though for things to compile. Kubernetes 1.4 is using kubernetes-client 6.x and overrides the direct dependency to 7.x causing compilation to fail.
adietish
changed the title
| args.add("login"); | ||
| args.add(url); | ||
| args.add("--insecure-skip-tls-verify"); | ||
| addKubeconfigParameter(args); |
There was a problem hiding this comment.
this is the main change here. Use --kubeconfig so that the contexts that are defined in the other configs files are not dumped into the first one. Only a new context for the cluster (that we're logging in) is added.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbouchet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
…t-developer#966) Signed-off-by: Andre Dietisheim <[email protected]>
…wn one Signed-off-by: Andre Dietisheim <[email protected]>
|
New changes are detected. LGTM label has been removed. |
|
/override "ci/prow/e2e-openshift" |
|
@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override "Integration UI Tests with Local Kind Cluster Context Report" |
|
@adietish: Overrode contexts on behalf of adietish: Integration UI Tests with Local Kind Cluster Context Report In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
openshift-merge-bot
bot
merged commit d3ee695
into
redhat-developer:main
depends on redhat-developer/intellij-common#264
fixes #966