Skip to content

Commit f0a7743

Browse files
authored
Merge branch 'master' into ali/drop_graph_support
2 parents c54cb89 + a8cbc49 commit f0a7743

File tree

4 files changed

+37
-1
lines changed

4 files changed

+37
-1
lines changed

.github/wordlist.txt

+1
Original file line numberDiff line numberDiff line change
@@ -23,3 +23,4 @@ TimeSeries
2323
triaging
2424
www
2525
yml
26+
runsettings

.github/workflows/nuget-release.yml

+19
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,25 @@ jobs:
1919
run: dotnet --list-sdks
2020
- name: Check .NET runtimes
2121
run: dotnet --list-runtimes
22+
23+
- name: get version from tag
24+
id: get_version
25+
run: |
26+
realversion="${GITHUB_REF/refs\/tags\//}"
27+
realversion="${realversion//v/}"
28+
echo "VERSION=$realversion" >> $GITHUB_OUTPUT
29+
30+
- name: Update version in csproj
31+
run: |
32+
VERSION=${{ steps.get_version.outputs.VERSION }}
33+
echo "Setting version to $VERSION"
34+
35+
# Update the version in the NRedisStack.csproj file
36+
sed -i "s|<Version>.*</Version>|<Version>$VERSION</Version>|" ./src/NRedisStack/NRedisStack.csproj
37+
sed -i "s|<ReleaseVersion>.*</ReleaseVersion>|<ReleaseVersion>$VERSION</ReleaseVersion>|" ./src/NRedisStack/NRedisStack.csproj
38+
sed -i "s|<PackageVersion>.*</PackageVersion>|<PackageVersion>$VERSION</PackageVersion>|" ./src/NRedisStack/NRedisStack.csproj
39+
cat ./src/NRedisStack/NRedisStack.csproj
40+
2241
- name: Build
2342
run: dotnet pack -c Release --output .
2443
- name: Publish

CONTRIBUTING.md

+13
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,19 @@ e.g:
113113
dotnet test --environment="REDIS=127.17.0.1:6379"
114114
```
115115

116+
Most of the integration tests rely on specific server capabilities,
117+
so, to be able run matching test cases properly you will need to set `REDIS_VERSION` variable with your actual server version that tests running against.
118+
```bash
119+
dotnet test --environment="REDIS=<redisServer:port>" --environment="REDIS_VERSION=<redisServerVersion>"
120+
```
121+
e.g:
122+
```bash
123+
dotnet test --environment="REDIS=127.17.0.1:6379" --environment="REDIS_VERSION=7.4.0"
124+
```
125+
126+
If you are relying on an IDE to run the tests, then you can set these parameters in [.runsettings](.vscode/.runsettings) file.
127+
You also need to check if your IDE supports [settings.json](.vscode/settings.json) for this to work.
128+
116129
To run your tests against an oss cluster:
117130
```bash
118131
dotnet test --environment "REDIS_CLUSTER=<redisServer:port>" --environment "NUM_REDIS_CLUSTER_NODES=<number of nodes in the cluster>"

README.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,12 @@ ft.DropIndex("myIndex");
155155

156156
More examples can be found in the [examples folder](Examples).
157157

158+
## For Contributors
159+
To contribute NRedisStack, please see :point_right: [Contribution notes](CONTRIBUTING.md)
160+
158161
------
159162

160-
### Author
163+
# Author
161164

162165
NRedisStack is developed and maintained by [Redis Inc](https://redis.com). It can be found [here](
163166
https://github.com/redis/NRedisStack), or downloaded from [NuGet](https://www.nuget.org/packages/NRedisStack).

0 commit comments

Comments
 (0)