Skip to content

Commit 4c088a3

Browse files
authored
JSON integration tests now do not use the test-containers framework (#3203)
* Remove testcontainers for the purpose of JSON tests * Missed three tests
1 parent be083d8 commit 4c088a3

File tree

6 files changed

+22
-22
lines changed

6 files changed

+22
-22
lines changed

src/test/java/io/lettuce/core/commands/CommandInterfacesIntegrationTests.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -20,46 +20,33 @@
2020
package io.lettuce.core.commands;
2121

2222
import io.lettuce.core.RedisClient;
23-
import io.lettuce.core.RedisContainerIntegrationTests;
2423
import io.lettuce.core.RedisURI;
25-
import io.lettuce.core.TestSupport;
2624
import io.lettuce.core.api.StatefulConnection;
2725
import io.lettuce.core.api.StatefulRedisConnection;
2826
import io.lettuce.core.api.sync.RedisCommands;
2927
import io.lettuce.core.dynamic.Commands;
3028
import io.lettuce.core.dynamic.RedisCommandFactory;
3129
import io.lettuce.core.dynamic.annotation.Command;
3230
import io.lettuce.core.dynamic.annotation.Param;
33-
import io.lettuce.test.LettuceExtension;
34-
import io.lettuce.test.condition.EnabledOnCommand;
3531
import org.junit.jupiter.api.Assumptions;
3632
import org.junit.jupiter.api.BeforeEach;
3733
import org.junit.jupiter.api.Tag;
3834
import org.junit.jupiter.api.Test;
39-
import org.junit.jupiter.api.TestInstance;
40-
import org.junit.jupiter.api.extension.ExtendWith;
4135
import reactor.core.publisher.Flux;
4236

43-
import javax.inject.Inject;
4437
import java.lang.reflect.Proxy;
4538
import java.util.List;
4639

4740
import static io.lettuce.TestTags.INTEGRATION_TEST;
48-
import static io.lettuce.core.SetArgs.Builder.ex;
49-
import static io.lettuce.core.SetArgs.Builder.exAt;
50-
import static io.lettuce.core.SetArgs.Builder.px;
51-
import static io.lettuce.core.SetArgs.Builder.pxAt;
52-
import static io.lettuce.core.StringMatchResult.Position;
5341
import static org.assertj.core.api.Assertions.assertThat;
54-
import static org.assertj.core.api.Assertions.assertThatThrownBy;
5542

5643
/**
5744
* Integration tests for {@link io.lettuce.core.dynamic.annotation.Command}.
5845
*
5946
* @author Tihomir Mateev
6047
*/
6148
@Tag(INTEGRATION_TEST)
62-
public class CommandInterfacesIntegrationTests extends RedisContainerIntegrationTests {
49+
public class CommandInterfacesIntegrationTests {
6350

6451
protected static RedisClient client;
6552

src/test/java/io/lettuce/core/commands/ConsolidatedAclCommandIntegrationTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
* @author M Sazzadul Hoque
3838
*/
3939
@Tag(INTEGRATION_TEST)
40-
public class ConsolidatedAclCommandIntegrationTests extends RedisContainerIntegrationTests {
40+
public class ConsolidatedAclCommandIntegrationTests {
4141

4242
private static RedisClient client;
4343

src/test/java/io/lettuce/core/commands/ConsolidatedConfigurationCommandIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@
3131
import org.junit.jupiter.api.*;
3232

3333
import java.util.Collections;
34-
import java.util.Map;
3534

3635
/**
3736
* Integration tests for {@link io.lettuce.core.api.sync.RedisServerCommands} with Redis modules since Redis 8.0.
3837
*
3938
* @author M Sazzadul Hoque
4039
*/
4140
@Tag(INTEGRATION_TEST)
42-
public class ConsolidatedConfigurationCommandIntegrationTests extends RedisContainerIntegrationTests {
41+
public class ConsolidatedConfigurationCommandIntegrationTests {
4342

4443
private static RedisClient client;
4544

src/test/java/io/lettuce/core/json/RedisJsonClusterIntegrationTests.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
package io.lettuce.core.json;
99

10-
import io.lettuce.core.RedisContainerIntegrationTests;
1110
import io.lettuce.core.RedisURI;
1211
import io.lettuce.core.cluster.RedisClusterClient;
1312
import io.lettuce.core.cluster.api.async.RedisClusterAsyncCommands;
@@ -39,7 +38,7 @@
3938
import static org.assertj.core.api.Assertions.assertThat;
4039

4140
@Tag(INTEGRATION_TEST)
42-
public class RedisJsonClusterIntegrationTests extends RedisContainerIntegrationTests {
41+
public class RedisJsonClusterIntegrationTests {
4342

4443
protected static RedisClusterClient client;
4544

src/test/java/io/lettuce/core/json/RedisJsonIntegrationTests.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import io.lettuce.core.ClientOptions;
1111
import io.lettuce.core.RedisClient;
12-
import io.lettuce.core.RedisContainerIntegrationTests;
1312
import io.lettuce.core.RedisFuture;
1413
import io.lettuce.core.RedisURI;
1514
import io.lettuce.core.api.StatefulRedisConnection;
@@ -26,7 +25,6 @@
2625
import org.junit.jupiter.api.Test;
2726
import org.junit.jupiter.params.ParameterizedTest;
2827
import org.junit.jupiter.params.provider.ValueSource;
29-
import reactor.core.publisher.Mono;
3028
import reactor.test.StepVerifier;
3129

3230
import java.io.IOException;
@@ -43,7 +41,7 @@
4341
import static org.assertj.core.api.Assertions.assertThat;
4442

4543
@Tag(INTEGRATION_TEST)
46-
public class RedisJsonIntegrationTests extends RedisContainerIntegrationTests {
44+
public class RedisJsonIntegrationTests {
4745

4846
private static final String BIKES_INVENTORY = "bikes:inventory";
4947

src/test/resources/docker-env/docker-compose.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
x-client-libs-image: &client-libs-image
22
image: "redislabs/client-libs-test:${REDIS_VERSION:-8.0-M04-pre}"
3+
x-client-libs-stack-image: &client-libs-stack-image
4+
image: "redislabs/client-libs-test:${REDIS_STACK_VERSION:-8.0-M04-pre}"
35

46
services:
57
# Standalone Redis Servers
@@ -101,6 +103,21 @@ services:
101103
networks:
102104
- redis-network
103105

106+
standalone-stack:
107+
<<: *client-libs-stack-image
108+
environment:
109+
- REDIS_CLUSTER=no
110+
- PORT=6379
111+
ports:
112+
- "16379:6379"
113+
114+
clustered-stack:
115+
<<: *client-libs-stack-image
116+
environment:
117+
- REDIS_CLUSTER=yes
118+
- PORT=36379
119+
ports:
120+
- "36379-36381:36379-36381"
104121

105122
ssl-test-cluster:
106123
<<: *client-libs-image

0 commit comments

Comments
 (0)