From 79ed4b02710b52e5c8c1dc73b93e695eb0082610 Mon Sep 17 00:00:00 2001 From: kiryazovi-redis Date: Fri, 14 Feb 2025 15:34:47 +0200 Subject: [PATCH] fix review issues --- .github/workflows/benchmarks.yml | 6 ------ .github/workflows/integration.yml | 9 --------- README.md | 3 +-- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 9f2edd80b..19b38e891 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -56,12 +56,6 @@ jobs: env: JVM_OPTS: -Xmx3200m TERM: dumb - - name: Clean environment - run: | - make cleanup - env: - JVM_OPTS: -Xmx3200m - TERM: dumb - name: Tear down Docker Compose environment run: | docker compose $COMPOSE_ENV_FILES -f src/test/resources/docker-env/docker-compose.yml down diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index bec2165f9..f4ebe1dc9 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -24,7 +24,6 @@ jobs: fail-fast: false matrix: redis_version: - - "unstable" - "8.0" - "7.4" - "7.2" @@ -37,7 +36,6 @@ jobs: run: | # Map requested version to github or tag case "${{ matrix.redis_version }}" in - "unstable") redis_branch="unstable" stack_version="8.0-M04-pre" redis_test_version="8.0-M04-pre";; "8.0") redis_branch="8.0" stack_version="8.0-M04-pre" redis_test_version="8.0-M04-pre";; "7.4") redis_branch="7.4" stack_version="rs-7.4.0-v2" redis_test_version="7.4.2";; "7.2") redis_branch="7.2" stack_version="rs-7.2.0-v14" redis_test_version="7.2.7";; @@ -81,13 +79,6 @@ jobs: REDIS_STACK_VERSION: ${{ steps.map-tags.outputs.redis_stack_version }} JVM_OPTS: -Xmx3200m TERM: dumb - - name: Clean environment - run: | - sudo rm -rf $REDIS_ENV_WORK_DIR - make clean - env: - JVM_OPTS: -Xmx3200m - TERM: dumb - name: Tear down Docker Compose environment run: | docker compose $COMPOSE_ENV_FILES -f src/test/resources/docker-env/docker-compose.yml down diff --git a/README.md b/README.md index 2a34b6328..d06e87be9 100644 --- a/README.md +++ b/README.md @@ -155,7 +155,7 @@ Building ----------- Lettuce is built with Apache Maven. The tests require multiple running Redis instances for different test cases which -are configured using a ```Makefile```. Tests run by default against Redis `unstable`. +are configured using a ```Makefile```. Tests run by default against Redis `latest`. To build: @@ -163,7 +163,6 @@ To build: $ git clone https://github.com/redis/lettuce.git $ cd lettuce/ $ make docker-start -$ make docker-test ``` * Run the build: ```make docker-test```