Skip to content

Commit e0b9f0d

Browse files
author
Ruben Bridgewater
committed
Fix race condition in tests
1 parent 8c0d113 commit e0b9f0d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

52 files changed

+60
-60
lines changed

test/commands/blpop.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("The 'blpop' method", function () {
1515

1616
beforeEach(function (done) {
1717
client = redis.createClient.apply(redis.createClient, args);
18-
client.once("connect", function () {
18+
client.once("ready", function () {
1919
client.flushdb(done);
2020
});
2121
});

test/commands/dbsize.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("The 'dbsize' method", function () {
2323

2424
beforeEach(function (done) {
2525
client = redis.createClient.apply(redis.createClient, args);
26-
client.once("connect", function () {
26+
client.once("ready", function () {
2727
client.quit();
2828
});
2929
client.on('end', function () {
@@ -44,7 +44,7 @@ describe("The 'dbsize' method", function () {
4444

4545
beforeEach(function (done) {
4646
client = redis.createClient.apply(redis.createClient, args);
47-
client.once("connect", function () {
47+
client.once("ready", function () {
4848
client.flushdb(function (err, res) {
4949
helper.isString("OK")(err, res);
5050
done();

test/commands/del.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'del' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/eval.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("The 'eval' method", function () {
1616

1717
beforeEach(function (done) {
1818
client = redis.createClient.apply(redis.createClient, args);
19-
client.once("connect", function () {
19+
client.once("ready", function () {
2020
client.flushdb(done);
2121
});
2222
});

test/commands/exits.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'exits' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/expire.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'expire' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/flushdb.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("The 'flushdb' method", function () {
2323

2424
beforeEach(function (done) {
2525
client = redis.createClient.apply(redis.createClient, args);
26-
client.once("connect", function () {
26+
client.once("ready", function () {
2727
client.quit();
2828
});
2929
client.on('end', function () {
@@ -44,7 +44,7 @@ describe("The 'flushdb' method", function () {
4444

4545
beforeEach(function (done) {
4646
client = redis.createClient.apply(redis.createClient, args);
47-
client.once("connect", function () {
47+
client.once("ready", function () {
4848
done();
4949
});
5050
});

test/commands/geoadd.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'geoadd' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/get.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("The 'get' method", function () {
2323

2424
beforeEach(function (done) {
2525
client = redis.createClient.apply(redis.createClient, args);
26-
client.once("connect", function () {
26+
client.once("ready", function () {
2727
client.quit();
2828
});
2929
client.on('end', function () {
@@ -44,7 +44,7 @@ describe("The 'get' method", function () {
4444

4545
beforeEach(function (done) {
4646
client = redis.createClient.apply(redis.createClient, args);
47-
client.once("connect", function () {
47+
client.once("ready", function () {
4848
done();
4949
});
5050
});

test/commands/getset.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ describe("The 'getset' method", function () {
2424

2525
beforeEach(function (done) {
2626
client = redis.createClient.apply(redis.createClient, args);
27-
client.once("connect", function () {
27+
client.once("ready", function () {
2828
client.quit();
2929
});
3030
client.on('end', function () {
@@ -46,7 +46,7 @@ describe("The 'getset' method", function () {
4646

4747
beforeEach(function (done) {
4848
client = redis.createClient.apply(redis.createClient, args);
49-
client.once("connect", function () {
49+
client.once("ready", function () {
5050
done();
5151
});
5252
});

test/commands/hgetall.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("The 'hgetall' method", function () {
1616

1717
beforeEach(function (done) {
1818
client = redis.createClient.apply(redis.createClient, args);
19-
client.once("connect", function () {
19+
client.once("ready", function () {
2020
client.flushdb(done);
2121
});
2222
});
@@ -57,7 +57,7 @@ describe("The 'hgetall' method", function () {
5757

5858
beforeEach(function (done) {
5959
client = redis.createClient.apply(redis.createClient, args);
60-
client.once("connect", function () {
60+
client.once("ready", function () {
6161
client.flushdb(done);
6262
});
6363
});

test/commands/hincrby.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'hincrby' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/hlen.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'hlen' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/hmget.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ describe("The 'hmget' method", function () {
1616
beforeEach(function (done) {
1717
client = redis.createClient.apply(redis.createClient, args);
1818
client.once("error", done);
19-
client.once("connect", function () {
19+
client.once("ready", function () {
2020
client.flushdb();
2121
client.HMSET(hash, {"0123456789": "abcdefghij", "some manner of key": "a type of value"}, helper.isString('OK', done));
2222
});

test/commands/hmset.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("The 'hmset' method", function () {
1515

1616
beforeEach(function (done) {
1717
client = redis.createClient.apply(redis.createClient, args);
18-
client.once("connect", function () {
18+
client.once("ready", function () {
1919
client.flushdb(done);
2020
});
2121
});

test/commands/hset.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("The 'hset' method", function () {
1515

1616
beforeEach(function (done) {
1717
client = redis.createClient.apply(redis.createClient, args);
18-
client.once("connect", function () {
18+
client.once("ready", function () {
1919
client.flushdb(done);
2020
});
2121
});

test/commands/incr.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe("The 'incr' method", function () {
1717

1818
beforeEach(function (done) {
1919
client = redis.createClient.apply(redis.createClient, args);
20-
client.once("connect", function () {
20+
client.once("ready", function () {
2121
client.set(key, "9007199254740992", function (err, res) {
2222
helper.isNotError()(err, res);
2323
client.quit();
@@ -55,7 +55,7 @@ describe("The 'incr' method", function () {
5555
*/
5656
client = redis.createClient.apply(redis.createClient, args);
5757
client.once("error", done);
58-
client.once("connect", function () {
58+
client.once("ready", function () {
5959
client.set(key, "9007199254740992", function (err, res) {
6060
helper.isNotError()(err, res);
6161
done();

test/commands/keys.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ describe("The 'keys' method", function () {
1818
// This is going to test if the high water is also respected
1919
args.command_queue_high_water = 100;
2020
client = redis.createClient.apply(redis.createClient, args);
21-
client.once("connect", function () {
21+
client.once("ready", function () {
2222
client.flushdb(done);
2323
});
2424
});

test/commands/mget.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("The 'mget' method", function () {
1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
1717
client.once("error", done);
18-
client.once("connect", function () {
18+
client.once("ready", function () {
1919
client.flushdb();
2020
client.mset(["mget keys 1", "mget val 1", "mget keys 2", "mget val 2", "mget keys 3", "mget val 3"], done);
2121
});

test/commands/mset.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe("The 'mset' method", function () {
2525

2626
beforeEach(function (done) {
2727
client = redis.createClient.apply(redis.createClient, args);
28-
client.once("connect", function () {
28+
client.once("ready", function () {
2929
client.quit();
3030
});
3131
client.on('end', function () {
@@ -46,7 +46,7 @@ describe("The 'mset' method", function () {
4646

4747
beforeEach(function (done) {
4848
client = redis.createClient.apply(redis.createClient, args);
49-
client.once("connect", function () {
49+
client.once("ready", function () {
5050
done();
5151
});
5252
});

test/commands/msetnx.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'msetnx' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/multi.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("The 'multi' method", function () {
2323

2424
beforeEach(function (done) {
2525
client = redis.createClient.apply(redis.createClient, args);
26-
client.once("connect", function () {
26+
client.once("ready", function () {
2727
client.quit();
2828
});
2929
client.on('end', function () {

test/commands/randomkey.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'randomkey' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/rename.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'rename' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/renamenx.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'renamenx' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/rpush.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'rpush' command", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/sadd.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'sadd' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/scard.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'scard' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/script.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ describe("The 'script' method", function () {
1717

1818
beforeEach(function (done) {
1919
client = redis.createClient.apply(redis.createClient, args);
20-
client.once("connect", function () {
20+
client.once("ready", function () {
2121
client.flushdb(done);
2222
});
2323
});

test/commands/sdiff.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'sdiff' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/sdiffstore.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'sdiffstore' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/select.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ describe("The 'select' method", function () {
1515

1616
beforeEach(function (done) {
1717
client = redis.createClient.apply(redis.createClient, args);
18-
client.once("connect", function () {
18+
client.once("ready", function () {
1919
client.quit();
2020
});
2121
client.on('end', function () {

test/commands/set.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ describe("The 'set' method", function () {
2323

2424
beforeEach(function (done) {
2525
client = redis.createClient.apply(redis.createClient, args);
26-
client.once("connect", function () {
26+
client.once("ready", function () {
2727
client.quit();
2828
});
2929
client.on('end', function () {
@@ -44,7 +44,7 @@ describe("The 'set' method", function () {
4444

4545
beforeEach(function (done) {
4646
client = redis.createClient.apply(redis.createClient, args);
47-
client.once("connect", function () {
47+
client.once("ready", function () {
4848
done();
4949
});
5050
});

test/commands/setex.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'setex' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

test/commands/setnx.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ describe("The 'setnx' method", function () {
1313

1414
beforeEach(function (done) {
1515
client = redis.createClient.apply(redis.createClient, args);
16-
client.once("connect", function () {
16+
client.once("ready", function () {
1717
client.flushdb(done);
1818
});
1919
});

test/commands/sinter.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("The 'sinter' method", function () {
1414

1515
beforeEach(function (done) {
1616
client = redis.createClient.apply(redis.createClient, args);
17-
client.once("connect", function () {
17+
client.once("ready", function () {
1818
client.flushdb(done);
1919
});
2020
});

0 commit comments

Comments
 (0)