Skip to content

Commit 5991d62

Browse files
authored
fixed the load-stream bechmarks such that the memory footprint does not keep growing. (#205)
* fixed the load-stream bechmarks such that the memory footprint does not keep growing. * formatting using poetry run black
1 parent f9534ba commit 5991d62

5 files changed

+17
-10
lines changed

redis_benchmarks_specification/__runner__/runner.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -659,7 +659,12 @@ def process_self_contained_coordinator_stream(
659659

660660
if args.benchmark_local_install:
661661
logging.info("Running memtier benchmark outside of docker")
662-
benchmark_command_str = "taskset -c " + client_cpuset_cpus + " " + benchmark_command_str
662+
benchmark_command_str = (
663+
"taskset -c "
664+
+ client_cpuset_cpus
665+
+ " "
666+
+ benchmark_command_str
667+
)
663668
logging.info(
664669
"Running memtier benchmark command {}".format(
665670
benchmark_command_str
@@ -1037,7 +1042,9 @@ def data_prepopulation_step(
10371042
if benchmark_local_install:
10381043
logging.info("Running memtier benchmark outside of docker")
10391044

1040-
preload_command_str = "taskset -c " + client_cpuset_cpus + " " + preload_command_str
1045+
preload_command_str = (
1046+
"taskset -c " + client_cpuset_cpus + " " + preload_command_str
1047+
)
10411048
logging.info(
10421049
"Pre-loading using memtier benchmark command {}".format(
10431050
preload_command_str

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-load-stream-1-fields-with-100B-values-pipeline-10.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dbconfig:
88
keyspacelen: 0
99
resources:
1010
requests:
11-
memory: 12g
11+
memory: 5g
1212
tested-commands:
1313
- xadd
1414
redis-topologies:
@@ -18,7 +18,7 @@ build-variants:
1818
clientconfig:
1919
run_image: redislabs/memtier_benchmark:edge
2020
tool: memtier_benchmark
21-
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
21+
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ MAXLEN ~ 1 * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
2222
resources:
2323
requests:
2424
cpus: '4'

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-load-stream-1-fields-with-100B-values.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dbconfig:
88
keyspacelen: 0
99
resources:
1010
requests:
11-
memory: 1g
11+
memory: 5g
1212
tested-commands:
1313
- xadd
1414
redis-topologies:
@@ -18,7 +18,7 @@ build-variants:
1818
clientconfig:
1919
run_image: redislabs/memtier_benchmark:edge
2020
tool: memtier_benchmark
21-
arguments: '"--data-size" "100" --command "XADD __key__ * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
21+
arguments: '"--data-size" "100" --command "XADD __key__ MAXLEN ~ 1 * field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
2222
resources:
2323
requests:
2424
cpus: '4'

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-load-stream-5-fields-with-100B-values-pipeline-10.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dbconfig:
88
keyspacelen: 0
99
resources:
1010
requests:
11-
memory: 35g
11+
memory: 8g
1212
tested-commands:
1313
- xadd
1414
redis-topologies:
@@ -18,7 +18,7 @@ build-variants:
1818
clientconfig:
1919
run_image: redislabs/memtier_benchmark:edge
2020
tool: memtier_benchmark
21-
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
21+
arguments: '"--pipeline" "10" "--data-size" "100" --command "XADD __key__ MAXLEN ~ 5 * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
2222
resources:
2323
requests:
2424
cpus: '4'

redis_benchmarks_specification/test-suites/memtier_benchmark-1Mkeys-load-stream-5-fields-with-100B-values.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ dbconfig:
88
keyspacelen: 0
99
resources:
1010
requests:
11-
memory: 35g
11+
memory: 8g
1212
tested-commands:
1313
- xadd
1414
redis-topologies:
@@ -18,7 +18,7 @@ build-variants:
1818
clientconfig:
1919
run_image: redislabs/memtier_benchmark:edge
2020
tool: memtier_benchmark
21-
arguments: '"--data-size" "100" --command "XADD __key__ * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
21+
arguments: '"--data-size" "100" --command "XADD __key__ MAXLEN ~ 5 * field __data__ field __data__ field __data__ field __data__ field __data__" --command-key-pattern="P" --key-minimum=1 --key-maximum 1000000 --test-time 180 -c 50 -t 4 --hide-histogram'
2222
resources:
2323
requests:
2424
cpus: '4'

0 commit comments

Comments
 (0)