Skip to content

Commit d04e6b9

Browse files
committed
Fix prepare_vector_db method
1 parent 745c933 commit d04e6b9

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

redis_benchmarks_specification/__self_contained_coordinator__/clients.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,26 +25,24 @@ def prepare_memtier_benchmark_parameters(
2525

2626

2727
def prepare_vector_db_benchmark_parameters(
28-
clientconfig,
29-
full_benchmark_path,
30-
port,
31-
server,
28+
clientconfig, full_benchmark_path, port, server, password, client_mnt_point
3229
):
3330
benchmark_command = []
34-
if port is not None:
35-
benchmark_command.extend(["REDIS_PORT={}".format(port)])
31+
# if port is not None:
32+
# benchmark_command.extend(["REDIS_PORT={}".format(port)])
33+
# if password is not None:
34+
# benchmark_command.extend(["REDIS_AUTH={}".format(password)])
3635
benchmark_command.extend(
3736
[
3837
full_benchmark_path,
3938
"--host",
4039
f"{server}",
4140
]
4241
)
43-
benchmark_command.extend(
44-
["--engines", clientconfig.get("engines", "redis-test")]
45-
)
42+
benchmark_command.extend(["--engines", clientconfig.get("engines", "redis-test")])
4643
benchmark_command.extend(
4744
["--datasets", clientconfig.get("datasets", "glove-100-angular")]
4845
)
4946
benchmark_command_str = " ".join(benchmark_command)
47+
benchmark_command_str = f"bash -c 'ITERATIONS=1 {benchmark_command_str} && mv /code/results {client_mnt_point}.'"
5048
return None, benchmark_command_str

redis_benchmarks_specification/__self_contained_coordinator__/self_contained_coordinator.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
from redis_benchmarks_specification.__runner__.runner import (
6060
print_results_table_stdout,
6161
prepare_memtier_benchmark_parameters,
62-
prepare_vector_db_benchmark_parameters,
6362
)
6463
from redis_benchmarks_specification.__self_contained_coordinator__.args import (
6564
create_self_contained_coordinator_args,
@@ -112,6 +111,9 @@
112111
extract_db_cpu_limit,
113112
generate_cpuset_cpus,
114113
)
114+
from redis_benchmarks_specification.__self_contained_coordinator__.clients import (
115+
prepare_vector_db_benchmark_parameters,
116+
)
115117
from redis_benchmarks_specification.__self_contained_coordinator__.docker import (
116118
generate_standalone_redis_server_args,
117119
)

0 commit comments

Comments
 (0)