Skip to content

Commit 31d99ac

Browse files
committed
addressing comments
1 parent 37bf652 commit 31d99ac

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

aredis_om/model/model.py

+1-11
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,7 @@
2222
TypeVar,
2323
Union,
2424
)
25-
from typing import get_args as typing_get_args
26-
from typing import no_type_check
25+
from typing import get_args as typing_get_args, no_type_check
2726

2827
from more_itertools import ichunked
2928
from redis.commands.json.path import Path
@@ -1203,7 +1202,6 @@ def Field(
12031202
vector_options=vector_options,
12041203
**current_schema_extra,
12051204
)
1206-
# field_info._validate()
12071205
return field_info
12081206

12091207

@@ -1300,7 +1298,6 @@ def __new__(cls, name, bases, attrs, **kwargs): # noqa C901
13001298
else:
13011299
new_class.__annotations__[field_name] = ExpressionProxy
13021300
# Check if this is our FieldInfo version with extended ORM metadata.
1303-
# if isinstance(field.field_info, FieldInfo):
13041301
field_info = None
13051302
if hasattr(field, "field_info") and isinstance(field.field_info, FieldInfo):
13061303
field_info = field.field_info
@@ -1371,9 +1368,7 @@ def outer_type_or_annotation(field):
13711368

13721369

13731370
class RedisModel(BaseModel, abc.ABC, metaclass=ModelMeta):
1374-
# class RedisModel(BaseModel, abc.ABC):
13751371
pk: Optional[str] = Field(default=None, primary_key=True)
1376-
# pk: Optional[str] = Field(default=None, primary_key=True)
13771372

13781373
Meta = DefaultMeta
13791374

@@ -1646,11 +1641,6 @@ async def save(
16461641
) -> "Model":
16471642
self.check()
16481643
db = self._get_db(pipeline)
1649-
1650-
# if hasattr(self,'model_fields_set'):
1651-
# dict = {k: v for k, v in self.dict().items() if k in self.model_fields_set}
1652-
# else:
1653-
# dict = self.dict()
16541644
document = jsonable_encoder(self.dict())
16551645
# TODO: Wrap any Redis response errors in a custom exception?
16561646
await db.hset(self.key(), mapping=document)

0 commit comments

Comments
 (0)