Skip to content

Commit 7155b9a

Browse files
author
Andrew Brookins
committed
Lint
1 parent 2ffd4e6 commit 7155b9a

File tree

3 files changed

+92
-59
lines changed

3 files changed

+92
-59
lines changed

tests/conftest.py

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def key_prefix(redis):
2525
yield key_prefix
2626
_delete_test_keys(key_prefix, redis)
2727

28+
2829
@pytest.fixture(autouse=True)
2930
def delete_test_keys(redis, request, key_prefix):
3031
_delete_test_keys(key_prefix, redis)

tests/test_hash_model.py

+41-27
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,11 @@ class BaseHashModel(HashModel, abc.ABC):
2626
class Meta:
2727
global_key_prefix = key_prefix
2828

29-
3029
class Order(BaseHashModel):
3130
total: decimal.Decimal
3231
currency: str
3332
created_on: datetime.datetime
3433

35-
3634
class Member(BaseHashModel):
3735
first_name: str = Field(index=True)
3836
last_name: str = Field(index=True)
@@ -46,8 +44,9 @@ class Meta:
4644

4745
Migrator().run()
4846

49-
return namedtuple('Models', ['BaseHashModel', 'Order', 'Member'])(
50-
BaseHashModel, Order, Member)
47+
return namedtuple("Models", ["BaseHashModel", "Order", "Member"])(
48+
BaseHashModel, Order, Member
49+
)
5150

5251

5352
@pytest.fixture
@@ -130,6 +129,7 @@ class Address(m.BaseHashModel):
130129
postal_code: str
131130

132131
with pytest.raises(RedisModelError):
132+
133133
class InvalidMember(m.BaseHashModel):
134134
address: Address
135135

@@ -169,7 +169,7 @@ def test_updates_a_model(members, m):
169169

170170
def test_paginate_query(members, m):
171171
member1, member2, member3 = members
172-
actual = m.Member.find().sort_by('age').all(batch_size=1)
172+
actual = m.Member.find().sort_by("age").all(batch_size=1)
173173
assert actual == [member2, member1, member3]
174174

175175

@@ -202,7 +202,7 @@ def test_access_result_by_index_not_cached(members, m):
202202
def test_exact_match_queries(members, m):
203203
member1, member2, member3 = members
204204

205-
actual = m.Member.find(m.Member.last_name == "Brookins").sort_by('age').all()
205+
actual = m.Member.find(m.Member.last_name == "Brookins").sort_by("age").all()
206206
assert actual == [member2, member1]
207207

208208
actual = m.Member.find(
@@ -216,10 +216,14 @@ def test_exact_match_queries(members, m):
216216
actual = m.Member.find(m.Member.last_name != "Brookins").all()
217217
assert actual == [member3]
218218

219-
actual = m.Member.find(
220-
(m.Member.last_name == "Brookins") & (m.Member.first_name == "Andrew")
221-
| (m.Member.first_name == "Kim")
222-
).sort_by('age').all()
219+
actual = (
220+
m.Member.find(
221+
(m.Member.last_name == "Brookins") & (m.Member.first_name == "Andrew")
222+
| (m.Member.first_name == "Kim")
223+
)
224+
.sort_by("age")
225+
.all()
226+
)
223227
assert actual == [member2, member1]
224228

225229
actual = m.Member.find(
@@ -231,20 +235,28 @@ def test_exact_match_queries(members, m):
231235
def test_recursive_query_resolution(members, m):
232236
member1, member2, member3 = members
233237

234-
actual = m.Member.find(
235-
(m.Member.last_name == "Brookins")
236-
| (m.Member.age == 100) & (m.Member.last_name == "Smith")
237-
).sort_by('age').all()
238+
actual = (
239+
m.Member.find(
240+
(m.Member.last_name == "Brookins")
241+
| (m.Member.age == 100) & (m.Member.last_name == "Smith")
242+
)
243+
.sort_by("age")
244+
.all()
245+
)
238246
assert actual == [member2, member1, member3]
239247

240248

241249
def test_tag_queries_boolean_logic(members, m):
242250
member1, member2, member3 = members
243251

244-
actual = m.Member.find(
245-
(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
246-
| (m.Member.last_name == "Smith")
247-
).sort_by('age').all()
252+
actual = (
253+
m.Member.find(
254+
(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
255+
| (m.Member.last_name == "Smith")
256+
)
257+
.sort_by("age")
258+
.all()
259+
)
248260
assert actual == [member1, member3]
249261

250262

@@ -267,8 +279,12 @@ def test_tag_queries_punctuation(m):
267279
)
268280
member2.save()
269281

270-
assert m.Member.find(m.Member.first_name == "Andrew, the Michael").first() == member1
271-
assert m.Member.find(m.Member.last_name == "St. Brookins-on-Pier").first() == member1
282+
assert (
283+
m.Member.find(m.Member.first_name == "Andrew, the Michael").first() == member1
284+
)
285+
assert (
286+
m.Member.find(m.Member.last_name == "St. Brookins-on-Pier").first() == member1
287+
)
272288

273289
# Notice that when we index and query multiple values that use the internal
274290
# TAG separator for single-value exact-match fields, like an indexed string,
@@ -341,7 +357,7 @@ def test_tag_queries_negation(members, m):
341357
~(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
342358
| (m.Member.last_name == "Smith")
343359
)
344-
assert query.sort_by('age').all() == [member2, member3]
360+
assert query.sort_by("age").all() == [member2, member3]
345361

346362
actual = m.Member.find(
347363
(m.Member.first_name == "Andrew") & ~(m.Member.last_name == "Brookins")
@@ -355,7 +371,7 @@ def test_numeric_queries(members, m):
355371
actual = m.Member.find(m.Member.age == 34).all()
356372
assert actual == [member2]
357373

358-
actual = m.Member.find(m.Member.age > 34).sort_by('age').all()
374+
actual = m.Member.find(m.Member.age > 34).sort_by("age").all()
359375
assert actual == [member1, member3]
360376

361377
actual = m.Member.find(m.Member.age < 35).all()
@@ -367,15 +383,13 @@ def test_numeric_queries(members, m):
367383
actual = m.Member.find(m.Member.age >= 100).all()
368384
assert actual == [member3]
369385

370-
actual = m.Member.find(m.Member.age != 34).sort_by('age').all()
386+
actual = m.Member.find(m.Member.age != 34).sort_by("age").all()
371387
assert actual == [member1, member3]
372388

373-
actual = m.Member.find(~(m.Member.age == 100)).sort_by('age').all()
389+
actual = m.Member.find(~(m.Member.age == 100)).sort_by("age").all()
374390
assert actual == [member2, member1]
375391

376-
actual = m.Member.find(
377-
m.Member.age > 30, m.Member.age < 40
378-
).sort_by('age').all()
392+
actual = m.Member.find(m.Member.age > 30, m.Member.age < 40).sort_by("age").all()
379393
assert actual == [member2, member1]
380394

381395

tests/test_json_model.py

+50-32
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,13 @@ class BaseJsonModel(JsonModel, abc.ABC):
2727
class Meta:
2828
global_key_prefix = key_prefix
2929

30-
3130
class Note(EmbeddedJsonModel):
3231
# TODO: This was going to be a full-text search example, but
3332
# we can't index embedded documents for full-text search in
3433
# the preview release.
3534
description: str = Field(index=True)
3635
created_on: datetime.datetime
3736

38-
3937
class Address(EmbeddedJsonModel):
4038
address_line_1: str
4139
address_line_2: Optional[str]
@@ -45,17 +43,14 @@ class Address(EmbeddedJsonModel):
4543
postal_code: str = Field(index=True)
4644
note: Optional[Note]
4745

48-
4946
class Item(EmbeddedJsonModel):
5047
price: decimal.Decimal
5148
name: str = Field(index=True)
5249

53-
5450
class Order(EmbeddedJsonModel):
5551
items: List[Item]
5652
created_on: datetime.datetime
5753

58-
5954
class Member(BaseJsonModel):
6055
first_name: str = Field(index=True)
6156
last_name: str = Field(index=True)
@@ -72,8 +67,9 @@ class Member(BaseJsonModel):
7267

7368
Migrator().run()
7469

75-
return namedtuple('Models', ['BaseJsonModel', 'Note', 'Address', 'Item', 'Order', 'Member'])(
76-
BaseJsonModel, Note, Address, Item, Order, Member)
70+
return namedtuple(
71+
"Models", ["BaseJsonModel", "Note", "Address", "Item", "Order", "Member"]
72+
)(BaseJsonModel, Note, Address, Item, Order, Member)
7773

7874

7975
@pytest.fixture()
@@ -213,12 +209,14 @@ def test_updates_a_model(members, m):
213209

214210
# Or, updating a field in an embedded model:
215211
member2.update(address__city="Happy Valley")
216-
assert m.Member.find(m.Member.pk == member2.pk).first().address.city == "Happy Valley"
212+
assert (
213+
m.Member.find(m.Member.pk == member2.pk).first().address.city == "Happy Valley"
214+
)
217215

218216

219217
def test_paginate_query(members, m):
220218
member1, member2, member3 = members
221-
actual = m.Member.find().sort_by('age').all(batch_size=1)
219+
actual = m.Member.find().sort_by("age").all(batch_size=1)
222220
assert actual == [member2, member1, member3]
223221

224222

@@ -250,7 +248,11 @@ def test_access_result_by_index_not_cached(members, m):
250248

251249
def test_in_query(members, m):
252250
member1, member2, member3 = members
253-
actual = m.Member.find(m.Member.pk << [member1.pk, member2.pk, member3.pk]).sort_by('age').all()
251+
actual = (
252+
m.Member.find(m.Member.pk << [member1.pk, member2.pk, member3.pk])
253+
.sort_by("age")
254+
.all()
255+
)
254256
assert actual == [member2, member1, member3]
255257

256258

@@ -272,7 +274,7 @@ def test_update_query(members, m):
272274
def test_exact_match_queries(members, m):
273275
member1, member2, member3 = members
274276

275-
actual = m.Member.find(m.Member.last_name == "Brookins").sort_by('age').all()
277+
actual = m.Member.find(m.Member.last_name == "Brookins").sort_by("age").all()
276278
assert actual == [member2, member1]
277279

278280
actual = m.Member.find(
@@ -286,28 +288,36 @@ def test_exact_match_queries(members, m):
286288
actual = m.Member.find(m.Member.last_name != "Brookins").all()
287289
assert actual == [member3]
288290

289-
actual = m.Member.find(
290-
(m.Member.last_name == "Brookins") & (m.Member.first_name == "Andrew")
291-
| (m.Member.first_name == "Kim")
292-
).sort_by('age').all()
291+
actual = (
292+
m.Member.find(
293+
(m.Member.last_name == "Brookins") & (m.Member.first_name == "Andrew")
294+
| (m.Member.first_name == "Kim")
295+
)
296+
.sort_by("age")
297+
.all()
298+
)
293299
assert actual == [member2, member1]
294300

295301
actual = m.Member.find(
296302
m.Member.first_name == "Kim", m.Member.last_name == "Brookins"
297303
).all()
298304
assert actual == [member2]
299305

300-
actual = m.Member.find(m.Member.address.city == "Portland").sort_by('age').all()
306+
actual = m.Member.find(m.Member.address.city == "Portland").sort_by("age").all()
301307
assert actual == [member2, member1, member3]
302308

303309

304310
def test_recursive_query_expression_resolution(members, m):
305311
member1, member2, member3 = members
306312

307-
actual = m.Member.find(
308-
(m.Member.last_name == "Brookins")
309-
| (m.Member.age == 100) & (m.Member.last_name == "Smith")
310-
).sort_by('age').all()
313+
actual = (
314+
m.Member.find(
315+
(m.Member.last_name == "Brookins")
316+
| (m.Member.age == 100) & (m.Member.last_name == "Smith")
317+
)
318+
.sort_by("age")
319+
.all()
320+
)
311321
assert actual == [member2, member1, member3]
312322

313323

@@ -338,7 +348,7 @@ def test_full_text_search(members, m):
338348
member1.update(bio="Hates sunsets, likes beaches")
339349
member2.update(bio="Hates beaches, likes forests")
340350

341-
actual = m.Member.find(m.Member.bio % "beaches").sort_by('age').all()
351+
actual = m.Member.find(m.Member.bio % "beaches").sort_by("age").all()
342352
assert actual == [member2, member1]
343353

344354
actual = m.Member.find(m.Member.bio % "forests").all()
@@ -348,10 +358,14 @@ def test_full_text_search(members, m):
348358
def test_tag_queries_boolean_logic(members, m):
349359
member1, member2, member3 = members
350360

351-
actual = m.Member.find(
352-
(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
353-
| (m.Member.last_name == "Smith")
354-
).sort_by('age').all()
361+
actual = (
362+
m.Member.find(
363+
(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
364+
| (m.Member.last_name == "Smith")
365+
)
366+
.sort_by("age")
367+
.all()
368+
)
355369
assert actual == [member1, member3]
356370

357371

@@ -376,8 +390,12 @@ def test_tag_queries_punctuation(address, m):
376390
)
377391
member2.save()
378392

379-
assert m.Member.find(m.Member.first_name == "Andrew, the Michael").first() == member1
380-
assert m.Member.find(m.Member.last_name == "St. Brookins-on-Pier").first() == member1
393+
assert (
394+
m.Member.find(m.Member.first_name == "Andrew, the Michael").first() == member1
395+
)
396+
assert (
397+
m.Member.find(m.Member.last_name == "St. Brookins-on-Pier").first() == member1
398+
)
381399

382400
# Notice that when we index and query multiple values that use the internal
383401
# TAG separator for single-value exact-match fields, like an indexed string,
@@ -450,7 +468,7 @@ def test_tag_queries_negation(members, m):
450468
~(m.Member.first_name == "Andrew") & (m.Member.last_name == "Brookins")
451469
| (m.Member.last_name == "Smith")
452470
)
453-
assert query.sort_by('age').all() == [member2, member3]
471+
assert query.sort_by("age").all() == [member2, member3]
454472

455473
actual = m.Member.find(
456474
(m.Member.first_name == "Andrew") & ~(m.Member.last_name == "Brookins")
@@ -476,13 +494,13 @@ def test_numeric_queries(members, m):
476494
actual = m.Member.find(m.Member.age >= 100).all()
477495
assert actual == [member3]
478496

479-
actual = m.Member.find(~(m.Member.age == 100)).sort_by('age').all()
497+
actual = m.Member.find(~(m.Member.age == 100)).sort_by("age").all()
480498
assert actual == [member2, member1]
481499

482-
actual = m.Member.find(m.Member.age > 30, m.Member.age < 40).sort_by('age').all()
500+
actual = m.Member.find(m.Member.age > 30, m.Member.age < 40).sort_by("age").all()
483501
assert actual == [member2, member1]
484502

485-
actual = m.Member.find(m.Member.age != 34).sort_by('age').all()
503+
actual = m.Member.find(m.Member.age != 34).sort_by("age").all()
486504
assert actual == [member1, member3]
487505

488506

@@ -521,7 +539,7 @@ class SortableTarotWitch(m.BaseJsonModel):
521539

522540
with pytest.raises(RedisModelError):
523541

524-
class SortableFullTextSearchAlchemicalWitch(BaseJsonModel):
542+
class SortableFullTextSearchAlchemicalWitch(m.BaseJsonModel):
525543
# We don't support indexing a list of strings for full-text search
526544
# queries. Support for this feature is not planned.
527545
potions: List[str] = Field(index=True, full_text_search=True)

0 commit comments

Comments
 (0)