Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support Pydantic v2 #525

Closed
XChikuX opened this issue Jun 19, 2023 · 3 comments · Fixed by #603
Closed

[Enhancement] Support Pydantic v2 #525

XChikuX opened this issue Jun 19, 2023 · 3 comments · Fixed by #603

Comments

@XChikuX
Copy link

XChikuX commented Jun 19, 2023

image

Pydantic v2 comes with several performance and safety benefits due to being compiled in Rust with python bindings.

I'd love to see the models: HashModel, JsonModel, EmbeddedJsonModel all use the new and improved pydantic.

There maybe a small migration workflow, which the pydantic team is building a tool for.

@bonastreyair
Copy link
Contributor

take a look at https://docs.pydantic.dev/latest/migration/
also take a look at this tool that will automatically upgrade some of the changes for you: https://github.com/pydantic/bump-pydantic

@XChikuX
Copy link
Author

XChikuX commented Jul 14, 2023

So far, commit #533 does not successfully support Pydantic v2. Keeping this open.

@pr0ton11
Copy link

Also waiting for this to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants