Fixes units and pool name attribute

Signed-off-by: Elena Kolevska <elena@kolevska.com>

Author: elena-kolevska

redis/connection.py

@@ -2638,6 +2638,11 @@ def __init__(
         self._fork_lock = threading.RLock()
         self._lock = threading.RLock()
 
+        # Generate unique pool ID for observability (matches go-redis behavior)
+        import secrets
+
+        self._pool_id = secrets.token_hex(4)
+
         MaintNotificationsAbstractConnectionPool.__init__(
             self,
             maint_notifications_config=maint_notifications_config,
@@ -2906,8 +2911,10 @@ async def _mock(self, error: RedisError):
         pass
 
     def get_connection_count(self) -> List[tuple[int, dict]]:
+        from redis.observability.attributes import get_pool_name
+
         attributes = AttributeBuilder.build_base_attributes()
-        attributes[DB_CLIENT_CONNECTION_POOL_NAME] = repr(self)
+        attributes[DB_CLIENT_CONNECTION_POOL_NAME] = get_pool_name(self)
         free_connections_attributes = attributes.copy()
         in_use_connections_attributes = attributes.copy()
 

redis/observability/attributes.py

@@ -352,22 +352,26 @@ def get_pool_name(pool: "ConnectionPoolInterface") -> str:
     Get a short string representation of a connection pool for observability.
 
     This provides a concise pool identifier suitable for use as a metric attribute,
-    in the format: ClassName(host:port/db)
+    in the format: host:port_uniqueID (matching go-redis format)
 
     Args:
         pool: Connection pool instance
 
     Returns:
-        Short pool name in format "ClassName(host:port/db)"
+        Short pool name in format "host:port_uniqueID"
 
     Example:
         >>> pool = ConnectionPool(host='localhost', port=6379, db=0)
         >>> get_pool_name(pool)
-        'ConnectionPool(localhost:6379/0)'
+        'localhost:6379_a1b2c3d4'
     """
     host = pool.connection_kwargs.get("host", "unknown")
     port = pool.connection_kwargs.get("port", 6379)
-    db = pool.connection_kwargs.get("db", 0)
-    class_name = pool.__class__.__name__
 
-    return f"{class_name}({host}:{port}/{db})"
+    # Get unique pool ID if available (added for observability)
+    pool_id = getattr(pool, "_pool_id", "")
+
+    if pool_id:
+        return f"{host}:{port}_{pool_id}"
+    else:
+        return f"{host}:{port}"

redis/observability/metrics.py

@@ -128,7 +128,7 @@ def _init_connection_basic_metrics(self) -> None:
         """Initialize basic connection metrics."""
         self.connection_create_time = self.meter.create_histogram(
             name="db.client.connection.create_time",
-            unit="{seconds}",
+            unit="s",
             description="Time to create a new connection",
             explicit_bucket_boundaries_advisory=self.config.buckets_connection_create_time,
         )
@@ -155,7 +155,7 @@ def _init_connection_advanced_metrics(self) -> None:
 
         self.connection_wait_time = self.meter.create_histogram(
             name="db.client.connection.wait_time",
-            unit="{seconds}",
+            unit="s",
             description="Time to obtain an open connection from the pool",
             explicit_bucket_boundaries_advisory=self.config.buckets_connection_wait_time,
         )
@@ -170,7 +170,7 @@ def _init_command_metrics(self) -> None:
         """Initialize command execution metric instruments."""
         self.operation_duration = self.meter.create_histogram(
             name="db.client.operation.duration",
-            unit="{seconds}",
+            unit="s",
             description="Command execution duration",
             explicit_bucket_boundaries_advisory=self.config.buckets_operation_duration,
         )
@@ -187,7 +187,7 @@ def _init_streaming_metrics(self) -> None:
         """Initialize Streaming metric instruments."""
         self.stream_lag = self.meter.create_histogram(
             name="redis.client.stream.lag",
-            unit="{seconds}",
+            unit="s",
             description="End-to-end lag per message, showing how stale are the messages when the application starts processing them.",
             explicit_bucket_boundaries_advisory=self.config.buckets_stream_processing_duration,
         )
@@ -208,7 +208,7 @@ def _init_csc_metrics(self) -> None:
 
         self.csc_network_saved = self.meter.create_counter(
             name="redis.client.csc.network_saved",
-            unit="{bytes}",
+            unit="By",
             description="The total number of bytes saved by using CSC",
         )
 
@@ -314,7 +314,7 @@ def init_connection_count(
 
         self.connection_count = self.meter.create_observable_gauge(
             name="db.client.connection.count",
-            unit="connections",
+            unit="{connection}",
             description="Number of connections in the pool",
             callbacks=[callback],
         )