Skip to content

Commit 4e1e7f8

Browse files
author
root
committed
Avoid unnecessary permissions lookups (thanks rchady!)
1 parent 705297c commit 4e1e7f8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/redmine_gitolite/admin_repositories_helper.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,8 @@ def build_permissions(repository)
279279
read = []
280280

281281
rewind_users = users.select{|user| user.allowed_to?(:manage_repository, project)}
282-
write_users = users.select{|user| user.allowed_to?(:commit_access, project) && !user.allowed_to?(:manage_repository, project)}
283-
read_users = users.select{|user| user.allowed_to?(:view_changesets, project) && !user.allowed_to?(:commit_access, project) && !user.allowed_to?(:manage_repository, project)}
282+
write_users = users.select{|user| user.allowed_to?(:commit_access, project)} - rewind_users
283+
read_users = users.select{|user| user.allowed_to?(:view_changesets, project)} - rewind_users - write_users
284284

285285
if project.active?
286286
rewind = rewind_users.map{|user| user.gitolite_identifier}

0 commit comments

Comments
 (0)