Remove useless tests on Rails mass attributes

Author: n-rodriguez

Diff for: spec/models/gitolite_public_key_spec.rb

@@ -25,12 +25,6 @@ def test_user
 
     subject { @ssh_key }
 
-    ## Attributes
-    it { is_expected.to allow_mass_assignment_of(:title) }
-    it { is_expected.to allow_mass_assignment_of(:key) }
-    it { is_expected.to allow_mass_assignment_of(:key_type) }
-    it { is_expected.to allow_mass_assignment_of(:delete_when_unused) }
-
     ## Relations
     it { is_expected.to belong_to(:user) }
     it { is_expected.to have_many(:repository_deployment_credentials) }

Diff for: spec/models/repository_deployment_credential_spec.rb

@@ -27,10 +27,6 @@ def build_deployment_credential(opts = {})
 
     subject { @deployment_credential }
 
-    ## Attributes
-    it { should allow_mass_assignment_of(:perm) }
-    it { should allow_mass_assignment_of(:active) }
-
     ## Relations
     it { should belong_to(:repository) }
     it { should belong_to(:gitolite_public_key) }

Diff for: spec/models/repository_git_config_key_spec.rb

@@ -6,11 +6,6 @@
 
   subject { git_config_key }
 
-  ## Attributes
-  it { should allow_mass_assignment_of(:type) }
-  it { should allow_mass_assignment_of(:key) }
-  it { should allow_mass_assignment_of(:value) }
-
   ## Relations
   it { should belong_to(:repository) }
 

Diff for: spec/models/repository_git_extra_spec.rb

@@ -6,17 +6,6 @@
 
   subject { git_extra }
 
-  ## Attributes
-  it { should allow_mass_assignment_of(:git_http) }
-  it { should allow_mass_assignment_of(:git_daemon) }
-  it { should allow_mass_assignment_of(:git_notify) }
-  it { should allow_mass_assignment_of(:git_annex) }
-  it { should allow_mass_assignment_of(:default_branch) }
-  it { should allow_mass_assignment_of(:protected_branch) }
-  it { should allow_mass_assignment_of(:public_repo) }
-  it { should allow_mass_assignment_of(:key) }
-  it { should allow_mass_assignment_of(:urls_order) }
-
   ## Relations
   it { should belong_to(:repository) }
 

Diff for: spec/models/repository_mirror_spec.rb

@@ -40,14 +40,6 @@ def expect_valid_refspec(refspec)
 
     subject { @mirror }
 
-    ## Attributes
-    it { should allow_mass_assignment_of(:url) }
-    it { should allow_mass_assignment_of(:push_mode) }
-    it { should allow_mass_assignment_of(:include_all_branches) }
-    it { should allow_mass_assignment_of(:include_all_tags) }
-    it { should allow_mass_assignment_of(:explicit_refspec) }
-    it { should allow_mass_assignment_of(:active) }
-
     ## Relations
     it { should belong_to(:repository) }
 

Diff for: spec/models/repository_post_receive_url_spec.rb

@@ -6,14 +6,6 @@
 
   subject { post_receive_url }
 
-  ## Attributes
-  it { should allow_mass_assignment_of(:url) }
-  it { should allow_mass_assignment_of(:mode) }
-  it { should allow_mass_assignment_of(:active) }
-  it { should allow_mass_assignment_of(:use_triggers) }
-  it { should allow_mass_assignment_of(:triggers) }
-  it { should allow_mass_assignment_of(:split_payloads) }
-
   ## Relations
   it { should belong_to(:repository) }
 

Diff for: spec/models/repository_protected_branche_spec.rb

@@ -6,11 +6,6 @@
 
   subject { protected_branch }
 
-  ## Attributes
-  it { should allow_mass_assignment_of(:path) }
-  it { should allow_mass_assignment_of(:permissions) }
-  it { should allow_mass_assignment_of(:position) }
-
   ## Relations
   it { should belong_to(:repository) }
   it { should have_many(:protected_branches_members).with_foreign_key(:protected_branch_id).dependent(:destroy) }