Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve install process for angular 7-11 #121

Closed
wants to merge 1 commit into from
Closed

Improve install process for angular 7-11 #121

wants to merge 1 commit into from

Conversation

jepstein-eagle
Copy link

This modifies the peerDependencies so Angular 7-11 do not throw errors running npm install. This is especially important as npm 7 is stricter than prior npm versions and requires users to retry the command with --force, or --legacy-peer-deps as shown in this install example on an empty project:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"10.2.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^6.0.0 || ^12.0.0" from [email protected]
npm ERR! node_modules/angular-user-idle
npm ERR!   angular-user-idle@"2.2.7" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/user/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/user/.npm/_logs/2021-09-14T23_43_26_809Z-debug.log

I followed the >=VERSION convention from jest-preset-angular's package.json.

Resolves #120

BTW: This library is awesome @rednez ⭐

@Axinet
Copy link

Axinet commented Nov 12, 2021

@rednez it could be simple, yet a valuable addition. Now to have npm install lib without erros one have to use for example version 2.2.4 with Angular 10 instead of a newest one, to not have that missing peer library errors.

@tom-hartz
Copy link

tom-hartz commented Dec 7, 2021 •
edited
Loading

I am upgrading a project to Angular 13, and I am stuck with this error on npm install:

npm ERR! Found: @angular/[email protected]
...
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^6.0.0 || ^12.0.0" from [email protected]
npm ERR! node_modules/angular-user-idle
npm ERR!   angular-user-idle@"2.2.7" from the root project

I don't want to use --force, or --legacy-peer-deps if I can avoid it.

@rednez Let's get this PR merged! would simplify things for me on this project.

@jepstein-eagle
Copy link
Author

@rednez Can we please get this PR merged?

@nikuelias
Copy link

I just updated to Angular 13 and it would be great to have this updated. Please @rednez!

@sthompson-celerity
Copy link

@rednez Is this library dead?

@sthompson-celerity sthompson-celerity mentioned this pull request Jun 16, 2022
Closed
@rednez
Copy link
Owner

rednez commented Jun 16, 2022

@rednez Is this library dead?

And yes and no :)
I suppose You didn't read README file where It is written following "Unfortunately, This library was written for needs of my corporate project and this library compiles and works (Angular 6+) very well and as I expected. I don't have necessary time to maintenance my library as fast as you can expected. I have a plan to review my code to try to fix a bugs that was reported by other users but I don't know when I do it."
If you are disappointed by inadequate support from my side you are free to fork my repo or be patient :)

@rednez rednez closed this Jun 16, 2022
@rienheuver
Copy link

Why was this PR closed @rednez ? This would automatically add support for Angular 14 such as in !136. Perhaps you have a good reason for closing it of course, could you maybe explain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthompson-celerity sthompson-celerity sthompson-celerity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reported as incompatible dependency when using ng cli
7 participants
@jepstein-eagle @Axinet @tom-hartz @nikuelias @sthompson-celerity @rednez @rienheuver