Skip to content

Commit baae05e

Browse files
committed
Wrap everything in act()
1 parent edd4387 commit baae05e

File tree

2 files changed

+56
-18
lines changed

2 files changed

+56
-18
lines changed

packages/toolkit/src/query/tests/refetchingBehaviors.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ describe('refetchOnFocus tests', () => {
7272
expect(screen.getByTestId('amount').textContent).toBe('1')
7373
)
7474

75-
act(() => {
75+
await act(async () => {
7676
fireEvent.focus(window)
7777
})
7878

packages/toolkit/src/query/tests/useMutation-fixedCacheKey.test.tsx

Lines changed: 55 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
import { createApi } from '@reduxjs/toolkit/query/react'
22
import { setupApiStore, waitMs } from './helpers'
33
import React from 'react'
4-
import { render, screen, getByTestId, waitFor } from '@testing-library/react'
4+
import {
5+
render,
6+
screen,
7+
getByTestId,
8+
waitFor,
9+
act,
10+
} from '@testing-library/react'
511

612
describe('fixedCacheKey', () => {
713
const api = createApi({
@@ -55,7 +61,9 @@ describe('fixedCacheKey', () => {
5561
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
5662
expect(getByTestId(c2, 'status').textContent).toBe('uninitialized')
5763

58-
getByTestId(c1, 'trigger').click()
64+
act(() => {
65+
getByTestId(c1, 'trigger').click()
66+
})
5967

6068
await waitFor(() =>
6169
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -77,7 +85,9 @@ describe('fixedCacheKey', () => {
7785
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
7886
expect(getByTestId(c2, 'status').textContent).toBe('uninitialized')
7987

80-
getByTestId(c1, 'trigger').click()
88+
act(() => {
89+
getByTestId(c1, 'trigger').click()
90+
})
8191

8292
await waitFor(() => {
8393
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -87,8 +97,9 @@ describe('fixedCacheKey', () => {
8797
})
8898

8999
// test reset from the other component
90-
getByTestId(c2, 'reset').click()
91-
100+
act(() => {
101+
getByTestId(c2, 'reset').click()
102+
})
92103
await waitFor(() => {
93104
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
94105
expect(getByTestId(c1, 'data').textContent).toBe('')
@@ -117,7 +128,10 @@ describe('fixedCacheKey', () => {
117128
expect(getByTestId(c4, 'status').textContent).toBe('uninitialized')
118129

119130
// trigger with a component using the first cache key
120-
getByTestId(c1, 'trigger').click()
131+
132+
act(() => {
133+
getByTestId(c1, 'trigger').click()
134+
})
121135

122136
await waitFor(() =>
123137
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -136,7 +150,10 @@ describe('fixedCacheKey', () => {
136150
expect(getByTestId(c4, 'status').textContent).toBe('uninitialized')
137151

138152
// trigger with a component using the second cache key
139-
getByTestId(c3, 'trigger').click()
153+
154+
act(() => {
155+
getByTestId(c3, 'trigger').click()
156+
})
140157

141158
await waitFor(() =>
142159
expect(getByTestId(c3, 'status').textContent).toBe('fulfilled')
@@ -157,7 +174,10 @@ describe('fixedCacheKey', () => {
157174
})
158175

159176
// test reset from the component that triggered the mutation for the first cache key
160-
getByTestId(c1, 'reset').click()
177+
178+
act(() => {
179+
getByTestId(c1, 'reset').click()
180+
})
161181

162182
await waitFor(() => {
163183
// the components with the first cache key should be affected
@@ -187,7 +207,9 @@ describe('fixedCacheKey', () => {
187207
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
188208
expect(getByTestId(c2, 'status').textContent).toBe('uninitialized')
189209

190-
getByTestId(c1, 'trigger').click()
210+
act(() => {
211+
getByTestId(c1, 'trigger').click()
212+
})
191213

192214
await waitFor(() =>
193215
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -203,7 +225,9 @@ describe('fixedCacheKey', () => {
203225
let c1 = screen.getByTestId('C1')
204226
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
205227

206-
getByTestId(c1, 'trigger').click()
228+
act(() => {
229+
getByTestId(c1, 'trigger').click()
230+
})
207231

208232
await waitFor(() =>
209233
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -232,7 +256,9 @@ describe('fixedCacheKey', () => {
232256
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
233257
expect(getByTestId(c2, 'status').textContent).toBe('uninitialized')
234258

235-
getByTestId(c1, 'trigger').click()
259+
act(() => {
260+
getByTestId(c1, 'trigger').click()
261+
})
236262

237263
await waitFor(() =>
238264
expect(getByTestId(c1, 'status').textContent).toBe('fulfilled')
@@ -251,7 +277,9 @@ describe('fixedCacheKey', () => {
251277
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
252278
expect(getByTestId(c1, 'originalArgs').textContent).toBe('undefined')
253279

254-
getByTestId(c1, 'trigger').click()
280+
act(() => {
281+
getByTestId(c1, 'trigger').click()
282+
})
255283

256284
expect(getByTestId(c1, 'originalArgs').textContent).toBe('C1')
257285
})
@@ -264,7 +292,9 @@ describe('fixedCacheKey', () => {
264292
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
265293
expect(getByTestId(c1, 'originalArgs').textContent).toBe('undefined')
266294

267-
getByTestId(c1, 'trigger').click()
295+
await act(async () => {
296+
getByTestId(c1, 'trigger').click()
297+
})
268298

269299
expect(getByTestId(c1, 'originalArgs').textContent).toBe('undefined')
270300
})
@@ -289,24 +319,32 @@ describe('fixedCacheKey', () => {
289319
expect(getByTestId(c1, 'status').textContent).toBe('uninitialized')
290320
expect(getByTestId(c2, 'status').textContent).toBe('uninitialized')
291321

292-
getByTestId(c1, 'trigger').click()
322+
act(() => {
323+
getByTestId(c1, 'trigger').click()
324+
})
293325

294326
expect(getByTestId(c1, 'status').textContent).toBe('pending')
295327
expect(getByTestId(c1, 'data').textContent).toBe('')
296328

297-
getByTestId(c2, 'trigger').click()
329+
act(() => {
330+
getByTestId(c2, 'trigger').click()
331+
})
298332

299333
expect(getByTestId(c1, 'status').textContent).toBe('pending')
300334
expect(getByTestId(c1, 'data').textContent).toBe('')
301335

302-
resolve1!('this should not show up any more')
336+
act(() => {
337+
resolve1!('this should not show up any more')
338+
})
303339

304340
await waitMs()
305341

306342
expect(getByTestId(c1, 'status').textContent).toBe('pending')
307343
expect(getByTestId(c1, 'data').textContent).toBe('')
308344

309-
resolve2!('this should be visible')
345+
act(() => {
346+
resolve2!('this should be visible')
347+
})
310348

311349
await waitMs()
312350

0 commit comments

Comments
 (0)