Skip to content

Commit 6920371

Browse files
chore(broadcast): better logging and increased sendbuffer
1 parent 5c68674 commit 6920371

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

clientserver.go

+11-5
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ func createReq(ctx, clientCtx context.Context, cancel context.CancelFunc, req pr
110110
case <-clientCtx.Done():
111111
// client provided ctx
112112
if logger != nil {
113-
logger.Warn("clientserver: stopped by client")
113+
logger.Warn("clientserver: stopped by client", "cancelled", true)
114114
}
115115
return
116116
case <-ctx.Done():
@@ -124,7 +124,7 @@ func createReq(ctx, clientCtx context.Context, cancel context.CancelFunc, req pr
124124
// goes down.
125125
close(doneChan)
126126
if logger != nil {
127-
logger.Warn("clientserver: stopped by server")
127+
logger.Warn("clientserver: stopped by server", "cancelled", true)
128128
}
129129
return
130130
case resp := <-respChan:
@@ -135,11 +135,17 @@ func createReq(ctx, clientCtx context.Context, cancel context.CancelFunc, req pr
135135
if done {
136136
select {
137137
case doneChan <- response:
138+
if logger != nil {
139+
logger.Info("clientserver: req done", "cancelled", false)
140+
}
138141
case <-ctx.Done():
142+
if logger != nil {
143+
logger.Warn("clientserver: req done but stopped by server", "cancelled", true)
144+
}
139145
case <-clientCtx.Done():
140-
}
141-
if logger != nil {
142-
logger.Info("clientserver: req done")
146+
if logger != nil {
147+
logger.Warn("clientserver: req done but cancelled by client", "cancelled", true)
148+
}
143149
}
144150
close(doneChan)
145151
return

opts.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type managerOptions struct {
2626
func newManagerOptions() managerOptions {
2727
return managerOptions{
2828
backoff: backoff.DefaultConfig,
29-
sendBuffer: 50,
29+
sendBuffer: 100,
3030
nodeDialTimeout: 50 * time.Millisecond,
3131
// Provide an illegal machineID to avoid unintentional collisions.
3232
// 0 is a valid MachineID and should not be used as default.

0 commit comments

Comments
 (0)