Skip to content

Commit 625fdd4

Browse files
authored
Do not activate TREGO by default (#198)
* Do not activate TREGO by default * Adjust test assertion
1 parent ebdde79 commit 625fdd4

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

ego/src/egor.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -388,13 +388,14 @@ mod tests {
388388

389389
#[test]
390390
#[serial]
391-
fn test_xsinx_wb2_egor_builder() {
391+
fn test_xsinx_trego_wb2_egor_builder() {
392392
let res = EgorBuilder::optimize(xsinx)
393393
.configure(|config| {
394394
config
395395
.max_iters(20)
396396
.regression_spec(RegressionSpec::ALL)
397397
.correlation_spec(CorrelationSpec::ALL)
398+
.trego(true)
398399
.seed(1)
399400
})
400401
.min_within(&array![[0.0, 25.0]])
@@ -418,7 +419,7 @@ mod tests {
418419

419420
#[test]
420421
#[serial]
421-
fn test_xsinx_checkpoint_egor() {
422+
fn test_xsinx_hot_start_egor() {
422423
let _ = std::fs::remove_file(".checkpoints/egor.arg");
423424
let n_iter = 1;
424425
let res = EgorBuilder::optimize(xsinx)
@@ -532,7 +533,7 @@ mod tests {
532533

533534
#[test]
534535
#[serial]
535-
fn test_rosenbrock_2d_no_trego_egor_builder() {
536+
fn test_rosenbrock_2d_trego_egor_builder() {
536537
let outdir = "target/test_trego";
537538
let _ = std::fs::remove_file(format!("{outdir}/{DOE_INITIAL_FILE}"));
538539
let _ = std::fs::remove_file(format!("{outdir}/{DOE_FILE}"));
@@ -549,15 +550,16 @@ mod tests {
549550
.max_iters(max_iters)
550551
.outdir(outdir)
551552
.seed(42)
552-
.trego(false)
553+
.trego(true)
553554
})
554555
.min_within(&xlimits)
555556
.run()
556557
.expect("Minimize failure");
557558
let filepath = std::path::Path::new(&outdir).join(DOE_FILE);
558559
assert!(filepath.exists());
559560
let doe: Array2<f64> = read_npy(&filepath).expect("file read");
560-
assert_eq!(doe.nrows(), init_doe.nrows() + max_iters); // we get one point per iter
561+
assert!(doe.nrows() <= init_doe.nrows() + max_iters);
562+
assert!(doe.nrows() >= init_doe.nrows());
561563

562564
println!("Rosenbrock optim result = {res:?}");
563565
println!("Elapsed = {:?}", now.elapsed());

ego/src/solver/egor_config.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ pub(crate) struct TregoConfig {
2121
impl Default for TregoConfig {
2222
fn default() -> Self {
2323
TregoConfig {
24-
activated: true,
24+
activated: false,
2525
n_local_steps: 4,
2626
d: (1e-6, 1.),
2727
beta: 0.9,

0 commit comments

Comments
 (0)