Skip to content

Commit 6f9ae44

Browse files
Merge pull request #1127 from remarkablemark/fix/dom-to-react
fix(dom-to-react): default props.children to `undefined` instead of `null`
2 parents 57571aa + a6978c3 commit 6f9ae44

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

__tests__/dom-to-react.test.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe('domToReact', () => {
8484

8585
it('does not have `children` for void elements', () => {
8686
const reactElement = domToReact(htmlToDOM(html.img)) as JSX.Element;
87-
expect(reactElement.props.children).toBe(null);
87+
expect(reactElement.props.children).toBe(undefined);
8888
});
8989

9090
it('does not throw an error for void elements', () => {

src/dom-to-react.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export default function domToReact(
9696
props = attributesToProps(element.attribs, element.name);
9797
}
9898

99-
let children = null;
99+
let children;
100100

101101
switch (node.type) {
102102
case 'script':

0 commit comments

Comments
 (0)