-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Will Remix-PWA support the move to React Router v7? #284
Comments
Remix PWA would support react router as well as Remix. React Router v7 is very similar to Remix, and my goal is to ensure wether you choose to use existing Remix versions, or new React router versions, Remix PWA would provide support for them |
Hi, thanks for the hard work here! Just curious if there is a timeline in mind? I tried remix-pwa v3 today and noticed that it was not compatible with react-router v7, because remix-pwa made assumption that As someone new to do this package, I would love to know whether v5 is almost ready, or should I give v4 a try? |
The docs also has a next section that's dedicated to v5, the docs aren't fully done yet tho. Regarding the timeline, I don't have one. React Router v7 is similar to Remix, but with a few distinctions that I need to explore |
Hey @ShafSpecs. Any movement on this? |
Yeah, it's been pretty slow and would be a dev release for a while, but I am working on this |
@ShafSpecs Is there a github branch i can try out for this? |
Not yet unfortunately, I am still trying to get React Router v7 to work on my machine |
Maybe I can help? Can you post the error? I have it working on a new react-router app, as well as upgraded a big remix application to it. |
This branch (v5-rc): https://github.com/remix-pwa/monorepo/tree/v5-rc/sandboxes/rr7 I re-worked the sandbox to contain remix spa apps, normal ssr apps and a react router v7 app. The Remix apps work, but React Router throws errors for some reason
|
Okay i got it working. Seems to be a problem with the sandbox being inside a workspace. Changes i made:
![]()
![]() I suspect that this problem exists only for npm workspaces since https://github.com/remix-run/react-router-templates uses pnpm which works. and I can tell from personal experience that yarn workspaces also work. Hope that points you in the right direction... |
Thanks for the fix @IgnisDa! Started work on |
Hi,
This seems like a great package. However, it seems Remix is "taking a pause" now that all the functionality has moved to React Router v7:
Will Remix-PWA publish future versions based around React Router v7 instead of Remix?
Thanks!
The text was updated successfully, but these errors were encountered: