Skip to content

createBrowserHistory() breaks history URL on iOS 11 #964

@noradium

Description

@noradium

Hello,

I found the bug that createBrowserHistory() breaks URL in history on iOS 11 (or below) safari.

Steps to reproduce

(Suppose following path was on https://example.com)

  1. /pageA (not call createBrowserHistory)
  2. /pageB (from link in pageA / has <base href="https://example.com"> tag / call createBrowserHistory)
  3. /pageC (from link in pageB)
  4. Browser Back

Expected Behavior

back to /pageB

Actual Behavior

back to /

My Thought

This behavior is probably due to webkit bug. (Bug 182678: replaceState cause back/forward malfunction on html page with tag)

replaceState without 3rd argument at https://github.com/remix-run/history/blob/dev/packages/history/index.ts#L439 causes.

There is a workaround to pass current URL like this.

    globalHistory.replaceState({ ...globalHistory.state, idx: index }, "", createHref(location));

I confirmed that it fixed the issue.

May I make a PR?

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions