Skip to content

Request for Guidance on Deno Template Removal #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zkdiff opened this issue Nov 24, 2024 · 8 comments
Closed

Request for Guidance on Deno Template Removal #5

zkdiff opened this issue Nov 24, 2024 · 8 comments

Comments

@zkdiff
Copy link

zkdiff commented Nov 24, 2024

Note: If the removal of the Deno template is transient, please disregard this issue—I understand changes like this happen during early/rapid/active development.

The Deno template for @remix-run/react-router-templates was recently created and then removed. I would like to understand the implications of this change for developers who may have been interested in using the template.

I'm seeking clarification on the following points, as it is unclear what the removal signals:

  • Is Deno v2 an officially supported target runtime/platform for RR v7?
  • Is a separate template no longer warranted due to Deno v2's Node.js compatibility improvements?
  • If I'd like to get started using RR v7 on Deno, where would you recommend I start?

Please let me know if additional information would help in addressing this issue.

Additional Context

Any insight or future roadmap details regarding Deno support would be greatly appreciated.

I'm also interested in contributing to the Deno template to help reintroduce or maintain support, if that would be helpful.

@redabacha
Copy link
Contributor

redabacha commented Nov 24, 2024

yeah this would be much appreciated knowing the remix's team stance on Deno v2 support. i've made a working template for RR v7 + Deno v2 based on the templates here (it uses typescript type checker for the app directory because Deno doesn't support rootDirs yet): https://github.com/redabacha/react-router-deno-template/. however it would be nice to see it officially supported.

@brookslybrand
Copy link
Contributor

Hey sorry this hasn't received any attention. The team definitely wants to have a Deno template. We deleted it because the deploy didn't work properly, and unfortunately we haven't had time to work on it since then.

@redabacha if your template is similar to the existing ones/the one we originally had, please definitely feel free to open up a PR and I'll try to get it in

@diecodev
Copy link

diecodev commented Feb 4, 2025

@brookslybrand deploy failed bc of this:

@brookslybrand
Copy link
Contributor

@brookslybrand deploy failed bc of this:

Nice!

If this gets fixed, I'm happy for someone to open up a PR to add back the deno template

@zkdiff
Copy link
Author

zkdiff commented Feb 16, 2025

dirty-shark-76 is reporting:

Deno/2.1.4 
 Hono! Hono! Hono! Hono! 
  Hono says this is Deno v2.x

So maybe it's time to revisit. I'll try to give it a spin tonight.

@diecodev
Copy link

@zkdiff As far as I know, the problem is not related to Hono but to the import of react-router in the entry server to stream component data using Node.js APIs.

However, I'll also take a look at it today :D

@redabacha
Copy link
Contributor

redabacha commented Feb 24, 2025

@redabacha if your template is similar to the existing ones/the one we originally had, please definitely feel free to open up a PR and I'll try to get it in

sorry i haven't checked on this thread in a while and yep it's pretty similar (except the custom express server stuff) and i've updated it so it only relies on the deno typechecker now. i will open a pr to add the deno template along with an example for adding a custom express/hono server that should work the same in both dev and prod.

@brookslybrand
Copy link
Contributor

I'm going to close this issue since the "request for guidance" has been given

If someone (@redabacha?) wants to open a PR with a working Deno example please tag me and I'll do my best to help get it in 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants