node-custom-server morgan logging not working

[mbrowne]

In the node-custom-server template, this line is too late:

react-router-templates/node-custom-server/server.js

Line 44 in c7adc61

app.use(morgan("tiny"));

This means that morgan won't run at all.

Personally I like just logging in production, since logging every request in development can be noisy. So I would move the morgan() call right below this line:

react-router-templates/node-custom-server/server.js

Line 39 in c7adc61

);

It could alternatively be moved above the "/assets" handler if you wanted to log requests to static assets as well.

[lasseklovstad]

I had the same issue for node-postgres template

[jdnichollsc]

morgan is too old, maybe replacing that with Pino is a better approach here for a production ready logger, e.g:

import pino, { LoggerOptions as PinoLoggerOptions } from "pino";
import { Request } from "express";
import crypto from "crypto";

type LoggerOptions = {
  level: string;
  serviceName: string;
};

export function createLoggerOptions({ level, serviceName }: LoggerOptions) {
  const isProduction = process.env.APP_ENV === "production";

  return <PinoLoggerOptions>{
    level,
    name: serviceName,
    formatters: {
      level(label) {
        return { level: label };
      },
    },
    base: { service: serviceName },
    transport: !isProduction
      ? {
          target: "pino-pretty",
          options: {
            colorize: true,
            translateTime: "SYS:standard",
            ignore: "pid,hostname",
          },
        }
      : undefined,
    // Generate a correlation ID for each request
    genReqId: (request: Request) => {
      const correlationId = request.headers["x-correlation-id"];
      return correlationId ?? crypto.randomUUID();
    },
  };
}

const logger = pino(
  createLoggerOptions({
    level: process.env.LOG_LEVEL ?? "info",
    serviceName: "web-app",
  }),
);

export default logger;

Dependencies:

    "pino": "9.6.0",
    "pino-http": "10.4.0",
    "pino-pretty": "13.0.0",

[brookslybrand]

Whoops, yeah this was doing nothing

I moved it up in #123 to at least get it to work. I imagine for anyone running their own custom server they'll do their own thing with logging, so this is really just to get you started

@jdnichollsc pino is good, happy to swap it out, but I would prefer a much simpler setup since these templates are meant to be really simple and not have a ton of boilerplate. If you have a simple setup you want to propose feel free to open up a PR