Skip to content

Commit c9009fb

Browse files
authored
chore: Upgrade to deno 1.42.3 (#931)
1 parent b672c37 commit c9009fb

File tree

9 files changed

+14
-10
lines changed

9 files changed

+14
-10
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
env:
1010
# be sure to also update these in other workflows
1111
DENO_DIR: deno_dir
12-
DENO_VERSION: "1.40.3"
12+
DENO_VERSION: "1.42.3"
1313

1414
jobs:
1515
build:

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ on:
1010
env:
1111
# be sure to also update these in other workflows
1212
DENO_DIR: deno_dir
13-
DENO_VERSION: "1.40.3"
13+
DENO_VERSION: "1.42.3"
1414

1515
jobs:
1616
lint:

.github/workflows/prepare-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111
env:
1212
# be sure to also update these in other workflows
1313
DENO_DIR: deno_dir
14-
DENO_VERSION: "1.40.3"
14+
DENO_VERSION: "1.42.3"
1515

1616
jobs:
1717
prepare-release:

.github/workflows/release-jsr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313
env:
1414
# be sure to also update these in other workflows
1515
DENO_DIR: deno_dir
16-
DENO_VERSION: "1.40.3"
16+
DENO_VERSION: "1.42.3"
1717

1818
permissions:
1919
contents: read

.github/workflows/release-npm.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ on:
1313
env:
1414
# be sure to also update these in other workflows
1515
DENO_DIR: deno_dir
16-
DENO_VERSION: "1.40.3"
16+
DENO_VERSION: "1.42.3"
1717

1818
permissions: {}
1919
jobs:

src/util/binarySerialization.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ export function binaryToUuid(buffer, offset = 0) {
161161
if (i == 3 || i == 5 || i == 7 || i == 9) str += "-";
162162
}
163163
if (allZeros) return null;
164-
return str;
164+
return /** @type {import("./util.js").UuidString} */ (str);
165165
}
166166

167167
/**

studio/src/network/studioConnections/StudioConnectionsManager.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export class StudioConnectionsManager {
4242
* But pages created by the build view should always be allowed.
4343
* Therefore, we create tokens for every page created by the build view.
4444
* Inspectors can provide these tokens when connecting, and we'll always allow the connection when the token is valid.
45-
* @type {Set<string>}
45+
* @type {Set<import("../../../../src/mod.js").UuidString>}
4646
*/
4747
#connectionTokens = new Set();
4848

@@ -397,7 +397,7 @@ export class StudioConnectionsManager {
397397
* regardless of its origin, the connection type, or whether internal connections are enabled.
398398
*/
399399
createConnectionToken() {
400-
const token = crypto.randomUUID();
400+
const token = /** @type {import("../../../../src/mod.js").UuidString} */ (crypto.randomUUID());
401401
this.#connectionTokens.add(token);
402402
return token;
403403
}

test/unit/studio/src/network/studioConnections/StudioConnectionsManager.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ async function basicTest({
5050
let randomUuid = 0;
5151
const mockUuid = stub(crypto, "randomUUID", () => {
5252
randomUuid++;
53-
return "random_uuid_" + randomUuid;
53+
return /** @type {`${string}-${string}-${string}-${string}-${string}`} */ ("random_uuid_" + randomUuid);
5454
});
5555
const oldLocation = window.location;
5656
try {

test/unit/studio/src/ui/popoverMenus/PopoverManager.test.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ testTypes({
120120

121121
Deno.test({
122122
name: "context menu creation",
123-
fn() {
123+
async fn() {
124124
const { manager, uninstall } = basicManager();
125125
try {
126126
assertEquals(manager.curtainEl.parentElement, null);
@@ -137,6 +137,10 @@ Deno.test({
137137

138138
assertEquals(manager.removePopover(contextMenu), true);
139139
assertEquals(manager.removePopover(contextMenu), false);
140+
141+
// Some extra code is run in the next event loop when creating a popover.
142+
// We need to wait for this code to run, otherwise the test sanitizer will complain.
143+
await waitForMicrotasks();
140144
} finally {
141145
uninstall();
142146
}

0 commit comments

Comments
 (0)