* new no-uri flag for preflight

* implement load additional spec from URIs

Author: nvanthao

cmd/preflight/cli/root.go

@@ -71,6 +71,7 @@ that a cluster meets the requirements to run an application.`,
 	// Dry run flag should be in cmd.PersistentFlags() flags made available to all subcommands
 	// Adding here to avoid that
 	cmd.Flags().Bool("dry-run", false, "print the preflight spec without running preflight checks")
+	cmd.Flags().Bool("no-uri", false, "When this flag is used, Preflight does not attempt to retrieve the spec referenced by the uri: field`")
 
 	k8sutil.AddFlags(cmd.Flags())
 

internal/specs/specs.go

@@ -361,3 +361,31 @@ func LoadFromCluster(ctx context.Context, client kubernetes.Interface, selectors
 		RawSpecs: rawSpecs,
 	})
 }
+
+// LoadAdditionalSpecFromURIs loads additional specs from the URIs provided in the troubleshoot kinds.
+// This function will modify kinds in place.
+func LoadAdditionalSpecFromURIs(ctx context.Context, kinds *loader.TroubleshootKinds) {
+	uris := kinds.GetURIs()
+	if len(uris) == 0 {
+		klog.Info("No additional URIs found in all specs")
+		return
+	}
+	for _, uri := range uris {
+		rawSpec, err := downloadFromHttpURL(ctx, uri, nil)
+		if err != nil {
+			klog.Warningf("failed to download spec from URI %q: %v", uri, err)
+			continue
+		}
+		k, err := loader.LoadSpecs(ctx, loader.LoadOptions{RawSpec: string(rawSpec)})
+		if err != nil {
+			klog.Warningf("failed to load spec from URI %q: %v", uri, err)
+			continue
+		}
+		kinds.Add(k)
+	}
+
+	// dedup these top level specs
+	kinds.SupportBundlesV1Beta2 = util.Dedup(kinds.SupportBundlesV1Beta2)
+	kinds.PreflightsV1Beta2 = util.Dedup(kinds.PreflightsV1Beta2)
+	kinds.HostPreflightsV1Beta2 = util.Dedup(kinds.HostPreflightsV1Beta2)
+}

pkg/loader/loader.go

@@ -131,6 +131,36 @@ func (kinds *TroubleshootKinds) ToYaml() (string, error) {
 	return strings.Join(rawList, "---\n"), nil
 }
 
+// GetURIs dynamically extracts all the URIs from the troubleshoot kinds
+// .Spec.Uri field
+func (kinds *TroubleshootKinds) GetURIs() []string {
+	uris := []string{}
+	obj := reflect.ValueOf(*kinds)
+
+	for i := 0; i < obj.NumField(); i++ {
+		field := obj.Field(i)
+		if field.Kind() != reflect.Slice {
+			continue
+		}
+
+		for count := 0; count < field.Len(); count++ {
+			val := field.Index(count)
+			specField := val.FieldByName("Spec")
+			if !specField.IsValid() {
+				continue
+			}
+			uriField := specField.FieldByName("Uri")
+			if !uriField.IsValid() || uriField.Kind() != reflect.String {
+				continue
+			}
+
+			uris = append(uris, uriField.String())
+		}
+	}
+
+	return uris
+}
+
 func NewTroubleshootKinds() *TroubleshootKinds {
 	return &TroubleshootKinds{}
 }

pkg/preflight/read_specs.go

@@ -29,6 +29,12 @@ func readSpecs(args []string) (*loader.TroubleshootKinds, error) {
 		return nil, err
 	}
 
+	// Load additional specs from URIs
+	// only when no-uri flag is not set
+	if !viper.GetBool("no-uri") {
+		specs.LoadAdditionalSpecFromURIs(ctx, kinds)
+	}
+
 	ret := loader.NewTroubleshootKinds()
 
 	// Concatenate all preflight inclusterSpecs that don't have an upload destination