Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some troubleshoot.sh types are missing the uri parameter #1557

Closed
banjoh opened this issue Jun 3, 2024 · 2 comments · Fixed by #1574
Closed

Some troubleshoot.sh types are missing the uri parameter #1557

banjoh opened this issue Jun 3, 2024 · 2 comments · Fixed by #1574
Labels
bug::normal type::bug Something isn't working

Comments

@banjoh
Copy link
Member

banjoh commented Jun 3, 2024

Bug Description

Troubleshoot.sh is designed to allow specs to be updatable using a uri parameter. This parameter would have a url pointing to the spec updates.

Not all top level type (types that collect analysers/collectors/redactors together) have this field defined. Here is the current state of affairs

Type Has URI field
Analyzer
Collector
HostCollector
HostPreflight
Preflight
Redactor
RemoteCollector
SupportBundle

Expected Behavior

All top level types need to have this field defined.

Additional Context

Tools that support updating specs need to check that the external spec being dowloaded is of the same kind.

@ajp-io
Copy link
Member

ajp-io commented Jun 10, 2024

@banjoh Is there also an issue open to address the fact that an unknown analyzer will look like a failure to an end-user?

@banjoh
Copy link
Member Author

banjoh commented Jun 11, 2024

@banjoh Is there also an issue open to address the fact that an unknown analyzer will look like a failure to an end-user?

We do. #1436. The description focuses on formatting of a spec but the issue is similar to a misspelled analyser in the spec which would be a non-existent one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::normal type::bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants