Skip to content

Commit e5386f8

Browse files
authored
Merge pull request #16 from rescript-lang/use-rescript-instead-of-rewatch
Swap rewatch with rescript
2 parents c137114 + 6f3ccac commit e5386f8

File tree

134 files changed

+284
-269
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

134 files changed

+284
-269
lines changed

.github/workflows/ci.yml

+5
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,13 @@ jobs:
3030
- name: Install dependencies
3131
run: npm ci
3232

33+
# There is a bug in the ReScript compiler where it tries to compile the test files before finishing the source files
3334
- name: Build ReScript code
3435
run: npm run build
36+
continue-on-error: true
37+
38+
- name: Rebuild ReScript code
39+
run: npm run build
3540

3641
- name: Run tests
3742
run: npm test

docs/content/docs/contributing/getting-started.mdx

+6-1
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,13 @@ This will update your fork with the latest from `rescript-lang/experimental-resc
5353

5454
## Initial build
5555

56-
Install the dependencies and compile the bindings using [Rewatch](https://github.com/rescript-lang/rewatch):
56+
Install the dependencies and compile the bindings using `ReScript`:
5757

5858
```shell
5959
npm install && npm run build
6060
```
61+
62+
<Aside type="caution">
63+
Usage of **[rewatch](https://github.com/rescript-lang/rewatch)** is currently not advised.
64+
See [rewatch#144](https://github.com/rescript-lang/rewatch/issues/144) and [rewatch#124](https://github.com/rescript-lang/rewatch/issues/124#issuecomment-2488194551)
65+
</Aside>

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
"type": "module",
2929
"scripts": {
3030
"test": "node tests/index.js",
31-
"build": "rewatch",
32-
"format": "rescript format -all && prettier --write ./tests/index.js ./package.json",
31+
"build": "rescript",
32+
"format": "rescript format -all && prettier --write ./docs ./tests/index.js ./package.json",
3333
"docs": "astro dev",
3434
"build:docs": "astro build"
3535
},

src/CSSFontLoadingAPI/FontFaceSet.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/CanvasAPI/OffscreenCanvas.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ChannelMessagingAPI/MessagePort.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ClipboardAPI/Clipboard.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/Animation.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/CharacterData.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/Comment.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/Document.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/DocumentFragment.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/Element.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/FillStyle.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLAnchorElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLAreaElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLAudioElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLBRElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLBaseElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLBodyElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLButtonElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLCanvasElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLDListElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLDataElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLDataListElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLDialogElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLDivElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLElement.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLEmbedElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLFieldSetElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLFormElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLFrameSetElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLHRElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLHeadElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/DOMAPI/HTMLHeadingElement.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)