Use fs api to check if string is a directory. (#1080)

* Use fs api to check if string is a directory.

* Changelog entry

* Use findReScriptVersionForProjectRoot

Author: nojaf

CHANGELOG.md

@@ -12,6 +12,10 @@
 
 ## master
 
+#### :bug: Bug fix
+
+- Fix: bug where incremental analysis does not work when the project folder contains a dot. https://github.com/rescript-lang/rescript-vscode/pull/1080
+
 ## 1.62.0
 
 #### :nail_care: Polish

server/src/server.ts

@@ -268,7 +268,7 @@ let openedFile = (fileUri: string, fileContent: string) => {
         filesDiagnostics: {},
         namespaceName:
           namespaceName.kind === "success" ? namespaceName.result : null,
-        rescriptVersion: utils.findReScriptVersion(projectRootPath),
+        rescriptVersion: utils.findReScriptVersionForProjectRoot(projectRootPath),
         bsbWatcherByEditor: null,
         bscBinaryLocation: utils.findBscExeBinary(projectRootPath),
         editorAnalysisLocation: utils.findEditorAnalysisBinary(projectRootPath),

server/src/utils.ts

@@ -165,6 +165,24 @@ export let findReScriptVersion = (
   }
 };
 
+export function findReScriptVersionForProjectRoot(projectRootPath:string) : string | undefined {
+  let rescriptBinary = lookup.findFilePathFromProjectRoot(
+    projectRootPath,
+    path.join(c.nodeModulesBinDir, c.rescriptBinName)
+  );
+
+  if (rescriptBinary == null) {
+    return undefined;
+  }
+
+  try {
+    let version = childProcess.execSync(`${rescriptBinary} -v`);
+    return version.toString().trim();
+  } catch (e) {
+    return undefined;
+  }
+}
+
 // This is the path for the _builtin_ legacy analysis, that works for versions 11 and below.
 let builtinBinaryPath: string | null = null;
 if (fs.existsSync(c.builtinAnalysisDevPath)) {